Fix incorrect behavior when preparing SELECT * preceded by a WITH #1179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1139 I introduced support for the
WITH
clause. My implementation contains a bug: preparing a query containing aSELECT *
preceded by aWITH
causes an error to be thrown.Consider the following statement:
An error is thrown when preparing this statement because the glob expansion procedure tries to determine the column names for the result by looking up the column names for the query
SELECT * from temp
. This does not work becausetemp
is a temporary view defined in theWITH
clause.To fix this, I modified the glob expansion procedure to include the
WITH
clause in the query used to look up the result column names.