Adds SchemaChanger to perform database schema changes #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfallet
approved these changes
Jul 25, 2022
It's a great thing to make it public, so that it's not implemented in each project, but only once, as it is standard in SQLite. |
|
@nathanfallet this wasn't meant to be merged yet, it's missing documentation, and some other bits |
|
@jberkel You marked it ready for review so I thought it was. I'm sorry for that. You can still publish the branch again and open a new PR for missing things. |
|
Ok, but I marked it as ready for review to get some feedback regarding the code, not to have it auto-merged! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly based on code I had already written for a personal project, which I've been meaning to integrate into SQLite for a while now. As such, it already had a bit of testing, but not much.
Open questions: should this be in SQLite.swift, or in another project? Which cases are not covered yet? What methods should be made public?
Fixes #1073