Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find only scrolls the first search result into view #2524

Closed
stephanrauh opened this issue Aug 24, 2024 · 1 comment
Closed

Find only scrolls the first search result into view #2524

stephanrauh opened this issue Aug 24, 2024 · 1 comment
Assignees
@stephanrauh
Labels
21 bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved

Comments

@stephanrauh
Copy link
Owner

stephanrauh commented Aug 24, 2024 •
edited
Loading

If you're searching a word that's multiple times on the page, only the first search result is scrolled into view. When jumping to the next search result, the page scrolls to the top.

This error only happens in the version 21.3.x versions.
@stephanrauh stephanrauh self-assigned this Aug 24, 2024
@stephanrauh stephanrauh added 21 bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. labels Aug 24, 2024
stephanrauh added a commit to stephanrauh/pdf.js that referenced this issue Aug 24, 2024
@stephanrauh
stephanrauh/ngx-extended-pdf-viewer#2339, stephanrauh/ngx-extended-pd…
be1e8ed 
…f-viewer#2524 the PDF viewer didn't scroll find matches reliably into view
stephanrauh added a commit to stephanrauh/pdf.js that referenced this issue Aug 24, 2024
@stephanrauh
stephanrauh/ngx-extended-pdf-viewer#2339, stephanrauh/ngx-extended-pd…
730abdc 
…f-viewer#2524 the PDF viewer didn't scroll find matches reliably into view
stephanrauh added a commit that referenced this issue Aug 24, 2024
@stephanrauh
#2339, #2524 the PDF viewer didn't scroll find matches reliably into …
4b0f91b 
…view
@stephanrauh
Copy link
Owner Author

The bugfix is going to land with version 21.3.4.

stephanrauh added a commit to stephanrauh/extended-pdf-viewer-showcase that referenced this issue Aug 26, 2024
@stephanrauh
stephanrauh/ngx-extended-pdf-viewer#2339, stephanrauh/ngx-extended-pd…
06aa5b7 
…f-viewer#2524 update the local version of the PdfFindController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
21 bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephanrauh