Skip to content

Commit

Permalink
updated the changelog and the readme after accidentally publishing th…
Browse files Browse the repository at this point in the history
…e new version with the wrong version number
  • Loading branch information
stephanrauh committed Oct 6, 2024
1 parent 4f24c92 commit a1b37d1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions projects/ngx-extended-pdf-viewer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@ This library provides an embeddable PDF viewer component. It's different from ot

Version 20.0.2 is a security fix. It solves CVE-2024-4367. I strongly recommend updating to the latest version of ngx-extended-pdf-viewer as soon as possible, or to version 20.0.2 as a minimum. Older versions contain a bug allowing malicious PDF files to run arbitrary code. Kudos go to GitHub users ScratchPDX and Deepak Shakya to tell me about it, so I could provide a hotfix during my vacations.

## Version 22.0: update to pdf.js 4.7
## Version 21.4: improved search UI and update to pdf.js 4.6 / 4.7

Version 22.0 updates to pdf.js 4.7. It offers the same functionality as version 21.4, but it's a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous

## Version 21.4: improved search UI and update to pdf.js 4.6
Version 21.4.5 updates to pdf.js 4.7. It offers the same functionality as version 21.4, but it's a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous. Unfortunately, I forgot to update the version number, so this version breaks semantic versioning. Addig insult to injury, npm does not allow me to revert publishing, so there's no way to fix this. The good news is that your application probably will still work, even if it uses the modified method.

Version 21.4 updates to pdf.js 4.6. It also improved the search functionality: the find button is hidden if there's no text layer in the PDF document (or at least in the first 20 pages of the PDF document - this seems to be a decent compromise between accuracy and performance). If there's no find button or no text layer, CTRL+F doesn't open the find bar.

Expand Down
2 changes: 1 addition & 1 deletion projects/ngx-extended-pdf-viewer/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -599,4 +599,4 @@
- 21.4.2 #2571 if the PDF viewer is destroyed while it's still initializing, it inevitably runs into errors; I've added an additional check, so there's one error message less; updated the bleeding edge branch (it might still be broken due to many changes of pdf.js)
- 21.4.3 caveat: this version accidentally broke the stable branch! Please update to version 21.4.4 instead. Intended changes: dependency updates; updated the bleeding edge branch
- 21.4.4 repaired the stable branch
- 22.0.0-alpha.0 updated the bleeding edge branch to pdf.js 4.7.76; this is a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous
- 21.4.5 updated the bleeding edge branch to pdf.js 4.7.76; this is a breaking change because `NgxExtendedPdfViewerService.addEditorAnnotation` is now asynchronous

0 comments on commit a1b37d1

Please sign in to comment.