Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let TP use injection on non public classes #227

Closed
stephanenicolas opened this issue Jul 24, 2017 · 0 comments
Closed

Let TP use injection on non public classes #227

stephanenicolas opened this issue Jul 24, 2017 · 0 comments
Labels
bug enhancement has PR
Milestone
1.0.8

Comments

@stephanenicolas
Copy link
Owner 

error: Class Foo is private. @Inject constructors are not allowed in non public classes.
    Foo(Bar bar) {

Should work for things that are package protected, protected, etc. private should be the only forbidden case.
@stephanenicolas stephanenicolas added this to the 1.0.8 milestone Jul 24, 2017
stephanenicolas added a commit that referenced this issue Aug 22, 2017
@stephanenicolas
addresses issue #227
b84d152
@stephanenicolas stephanenicolas mentioned this issue Aug 22, 2017
Merged
stephanenicolas added a commit that referenced this issue Aug 22, 2017
@stephanenicolas
Merge pull request #233 from stephanenicolas/sni/issue-227
3631c26 
addresses issue #227
stephanenicolas added a commit that referenced this issue Aug 22, 2017
@stephanenicolas
Update CHANGELOG.md
fb6d400 
After merging fixes for #196 and #227
@stephanenicolas stephanenicolas mentioned this issue Jul 3, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement has PR
Projects
None yet
Milestone
1.0.8
Development

No branches or pull requests
1 participant
@stephanenicolas