Add fallback DNS #414
Add fallback DNS #414
Conversation
There was a problem hiding this comment.
Please find StepSecurity AI-CodeWise code comments inline or below.
dnsproxy_test.go
Please refer to 1 inline comments.
.github/workflows/int.yml
Please refer to 1 inline comments.
Feedback
We appreciate your feedback in helping us improve the service! To provide feedback, please use emojis on this comment. If you find a comment helpful, give it a 👍. If they aren't useful, kindly express that with a 👎. If you have questions or detailed feedback, please create n GitHub issue in StepSecurity/AI-CodeWise.
| @@ -24,10 +24,12 @@ func TestDNSProxy_getResponse(t *testing.T) { | |||
| auditCache := InitCache(EgressPolicyAudit) | |||
| blockCache := InitCache(EgressPolicyBlock) | |||
| rrDnsGoogle, _ := dns.NewRR("dns.google. IN A 8.8.8.8") | |||
| rrDnsCloudflare, _ := dns.NewRR("cloudflare-dns.com. IN A 1.1.1.1") | |||
There was a problem hiding this comment.
[High]Use constants or environment variables instead of hardcoding values in the code
The code contains hardcoded values that could be reused multiple times. Hardcoding values in the code can make it difficult to maintain the code and could lead to security issues. Use constants or environment variables to store the values. This will make it easy to modify the values if needed and it will make your code easy to read and maintain. Avoid storing sensitive information in environment variables
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: us-west-2 | ||
| - run: aws s3 cp ./agent s3://step-security-agent/refs/heads/int/agent --acl public-read | ||
| - name: Integration test |
There was a problem hiding this comment.
[Low]Add Dockerfile to the repo and use it in the integration test step
Instead of using a docker image directly from GitHub, we can use a Dockerfile in the repo. This would give greater control over the image. Add a Dockerfile to create image for ghcr.io/step-security/integration-test/int:latest and use that Dockerfile in the integration test step.
No description provided.