Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/PAD: Enable/Disable Player LED for DualSense Controllers in Enhanced mode #3254

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

dreamsyntax
Copy link
Contributor

@dreamsyntax dreamsyntax commented Jul 19, 2024

Port of:
PCSX2/pcsx2#10864

Note, since the Copy function here does not exist in duckstation, this line was not added, everything else works just as on PCSX2.
I noticed RawInput was also not ported, but I didn't want to clutter this PR with both changes.

Reposting my description I originally posted in the PCSX2 PR below.


Description of Changes

This change adds a toggle to enable/disable the Player LED on DualSense controllers.
Not to be confused with the primary LED. The Player LED is a non-customizable bright white array of white LEDs that indicate the player number. Image of before and after.
image

The UI change is added to the LEDSettingsDialog / controllerledsettingsdialog.ui
image

Rationale behind Changes

  • RAW mode does not have Player LEDs on.
  • Turning on Enhanced Mode turns on the Player LED in addition to the primary LED.
  • There is no option to disable the Player LEDs currently. You can only customize the primary LED.
  • A user may want to completely disable all LEDs on their controller. Currently you can disable the Primary LED but not the Player LED. This is distracting/bright when playing in low lighting conditions.
  • You can already tell which player is which due to the customized primary LED colors.

Suggested Testing Steps

  1. Connect DualSense controller. Note the player LED is off.
  2. Turn on Enhanced DS4/DS5 mode under the DuckStation Controller Settings.
    -- if on master --
  3. Note the Player LED is ON. You can customize the Main LED but not the Player LED.
    -- if on this branch --
  4. Note the Player LED is still OFF.
  5. Enter the LED Settings Dialog [controllerledsettingsdialog.ui] (The lightbulb icon) and utilize the new Checkbox. You should see all connected controllers enable/disable their player indicator LEDs. You can customize the Main LED per-controller as usual.

@dreamsyntax dreamsyntax changed the title Qt: Toggle for DualSense Player LED Qt/PAD: Enable/Disable Player LED for DualSense Controllers in Enhanced mode Jul 20, 2024
@stenzek stenzek merged commit d9ada75 into stenzek:master Jul 21, 2024
0 of 5 checks passed
@dreamsyntax dreamsyntax deleted the dualsense-player-indicator branch August 6, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants