Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy a Stellar Asset Contract (SAC) for a Stellar asset using code #887

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

KodeSage
Copy link
Contributor

@KodeSage KodeSage commented Aug 7, 2024

Bounty PR closes #615

@KodeSage KodeSage marked this pull request as ready for review August 7, 2024 22:55
@KodeSage
Copy link
Contributor Author

KodeSage commented Aug 8, 2024

@briwylde08 this is ready for review.

@briwylde08
Copy link
Contributor

Thank you! We'll get this assigned and reviewed!

docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
docs/build/guides/conventions/deploy-sac-with-code.mdx Outdated Show resolved Hide resolved
@anataliocs anataliocs self-assigned this Aug 20, 2024
@anataliocs
Copy link
Contributor

Stellar Asset Contract deployed as expected

image

https://stellar.expert/explorer/testnet/contract/CBF2X6JDA5BRMITM5VIHACY6YVWX2NRJQ7YN7EN3KXHXWWX66Z3DSMFU
image

@KodeSage
Copy link
Contributor Author

Hi @anataliocs , Thank you for the feedbacks.
I pushed up the fixes, which includes

  • nesting of sections
  • editorial fixes

@KodeSage
Copy link
Contributor Author

Hello @briwylde08 @anataliocs , just checking in for the status of the review.

@briwylde08
Copy link
Contributor

Hi @KodeSage! Sorry for the delay! @anataliocs is out of town but will get to the re-review asap!

@KodeSage
Copy link
Contributor Author

KodeSage commented Sep 4, 2024

HI @briwylde08 @anataliocs , just checking in again for the status of the review.

@briwylde08
Copy link
Contributor

Hi @KodeSage!! Sorry for the delay here, will get this reviewed asap. Thank you for the flag!

@KodeSage
Copy link
Contributor Author

KodeSage commented Sep 4, 2024

Hi @KodeSage!! Sorry for the delay here, will get this reviewed asap. Thank you for the flag!

alright thank you @briwylde08

@anataliocs
Copy link
Contributor

@KodeSage Doing a final review now!

Copy link
Contributor

@anataliocs anataliocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out changes locally! LGTM 🚢 🚢 🚢

image

@KodeSage
Copy link
Contributor Author

KodeSage commented Sep 5, 2024

Checked out changes locally! LGTM 🚢 🚢 🚢

image

Thank you @anataliocs 🚀
Hi @briwylde08 this has been approved.

@briwylde08
Copy link
Contributor

Thanks again for your contribution @KodeSage! We'll take the award conversation back to the corresponding issue.

@briwylde08 briwylde08 merged commit 0f062e9 into stellar:main Sep 5, 2024
1 check passed
janewang pushed a commit that referenced this pull request Sep 12, 2024
…887)

* chores: initialization of SAC using code

* chores: added code walk through

* chores: code explanation
git add .

* chores: final code explaination

* editorial

* chores: updated code nitpicks

* chores: editorial fix

* Update docs/build/guides/conventions/deploy-sac-with-code.mdx

* Update docs/build/guides/conventions/deploy-sac-with-code.mdx

---------

Co-authored-by: Bri <92327786+briwylde08@users.noreply.github.com>
Co-authored-by: Chris Anatalio <anataliocs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a guide for deploying a Stellar Asset Contract for a Stellar asset using code
3 participants