Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new captive core flags to ledgerbackend toml #5309

Merged
merged 2 commits into from
May 10, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented May 9, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add new captive core toml options EMIT_SOROBAN_TRANSACTION_META_EXT_V1 and EMIT_LEDGER_CLOSE_META_EXT_V1

Why

These flags are used to emit more detailed Soroban fee information as defined here

@chowbao chowbao marked this pull request as ready for review May 9, 2024 22:01
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Going to take the opportunity to promote this issue that I think we should do address, and if addressed would eliminate the need for these updates:

cc @mollykarcher

@chowbao chowbao merged commit 57486f0 into master May 10, 2024
31 checks passed
@chowbao chowbao deleted the add-new-captive-core-flags branch May 10, 2024 16:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants