Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Check if there are newer ledger when requested ledger does not exist #4198

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 27, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

In DatabaseBackend.GetLedger(ctx, sequence) check if there are newer ledgers than sequence if ledger not found. If there are newer ledgers return an error.

Why

If Stellar-Core cursors were manually removed or updated, it's possible it run a maintenance removing older ledgers. In such situation DatabaseBackend.GetLedger would loop indefinitely waiting for a ledger to appear in the DB but it never will.

Known limitations

No tests because there is no test suite for DatabaseBackend.

@bartekn bartekn requested a review from a team January 27, 2022 19:30
@bartekn bartekn merged commit d9a619d into stellar:master Jan 28, 2022
@bartekn bartekn deleted the db-ingest-check-ledger-after branch January 28, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants