more cache output options supported

stechstudio · Jul 5, 2024 · 4927735 · 4927735
1 parent cb79150
commit 4927735
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/Builder.php b/src/Builder.php
@@ -102,11 +102,12 @@ public function getComment(): string
 
     public function cache($output): self
     {
-        if (!$output instanceof FileContract) {
-            $output = File::make($output);
-        }
-
-        $this->cacheOutputStream = $output->getWritableStream();
+        $this->cacheOutputStream = match (true) {
+            $output instanceof StreamInterface => $output,
+            $output instanceof FileContract    => $output->getWritableStream(),
+            is_string($output)                 => File::makeWriteable($output)->getWritableStream(),
+            default                            => throw new InvalidArgumentException('Invalid cache output provided'),
+        };
 
         return $this;
     }

diff --git a/src/Models/TempFile.php b/src/Models/TempFile.php
@@ -10,7 +10,7 @@
 
 class TempFile extends File
 {
-    protected function getDefaultZipPath()
+    protected function getDefaultZipPath(): string
     {
         // For temp files (raw data provided) you MUST specify the zip path
         throw new FilenameMissingException();