Change R extension from being a library to being a module

Recent versions of R now (properly) require the R extension to be compiled as a module, which means that on macos the library extension should become .so instead of .dylib.
stcorp · Jul 30, 2024 · b3a4e7f · b3a4e7f
1 parent d303699
commit b3a4e7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,11 +1,13 @@
-1.23 2024-07-29
+1.23 2024-07-30
 ~~~~~~~~~~~~~~~
 
 * Fixed numpy 2.x compatibility issues in python interface.
 
 * Added derivations to retrieve dry air mass/volume mixing ratio from H2O
   mass/volume mixing ratio with regard to dry air.
 
+* Fixed some issues with building the HARP R interface extension.
+
 * Updates to product ingestions:
   - S5P PAL L2 AOT: added support for cloud_fraction vs.
     effective_cloud_fraction split

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -623,7 +623,7 @@ if(HARP_BUILD_R)
   configure_file(
     ${CMAKE_CURRENT_SOURCE_DIR}/R/create_rds.r.in
     ${CMAKE_CURRENT_BINARY_DIR}/R/create_rds.r)
-  add_library(Rharp SHARED R/harp.c R/Rharp.def)
+  add_library(Rharp MODULE R/harp.c R/Rharp.def)
   set_target_properties(Rharp PROPERTIES PREFIX "")
   if(WIN32)
     add_custom_command(OUTPUT R/R.lib