review notes fixes

src/status_im/contexts/shell/qr_reader/view.cljs

@@ -19,7 +19,7 @@
    :theme :dark
    :text  (i18n/label :t/invalid-qr)})
 
-(defn- is-text-a-status-url-for-path?
+(defn- text-a-status-url-for-path?
   [text path]
   (some #(string/starts-with? text %) (router/prepend-status-urls path)))
 
@@ -71,11 +71,11 @@
   [scanned-text]
   (cond
     (or
-     (is-text-a-status-url-for-path? scanned-text router/community-with-data-path)
-     (is-text-a-status-url-for-path? scanned-text router/channel-path))
+     (text-a-status-url-for-path? scanned-text router/community-with-data-path)
+     (text-a-status-url-for-path? scanned-text router/channel-path))
     (debounce/debounce-and-dispatch [:universal-links/handle-url scanned-text] 300)
 
-    (is-text-a-status-url-for-path? scanned-text router/user-with-data-path)
+    (text-a-status-url-for-path? scanned-text router/user-with-data-path)
     (let [address (extract-id scanned-text)]
       (load-and-show-profile address))
 

src/utils/address.cljs

@@ -86,10 +86,14 @@
     "0xa"    "oeth:"
     nil))
 
-(defn is-metamask-address?
+(defn split-metamask-address
   [address]
   (re-find regx-metamask-address address))
 
+(defn metamask-address?
+  [address]
+  (boolean (split-metamask-address address)))
+
 (defn eip-3770-address?
   "Checks if address follows EIP-3770 format which is default for Status"
   [s]
@@ -98,11 +102,11 @@
 (defn supported-address?
   [s]
   (boolean (or (eip-3770-address? s)
-               (is-metamask-address? s))))
+               (metamask-address? s))))
 
 (defn metamask-address->status-address
   [metamask-address]
-  (when-let [[_ address metamask-network-suffix] (is-metamask-address? metamask-address)]
+  (when-let [[_ address metamask-network-suffix] (split-metamask-address metamask-address)]
     (when-let [status-network-prefix (eip-155-suffix->eip-3770-prefix metamask-network-suffix)]
       (str status-network-prefix address))))
 
@@ -112,11 +116,8 @@
     (eip-3770-address? address)
     address
 
-    (is-metamask-address? address)
-    (metamask-address->status-address address)
-
-    :else
-    nil))
+    (metamask-address? address)
+    (metamask-address->status-address address)))
 
 (defn extract-address-without-chains-info
   [address]

src/utils/address_test.cljs

@@ -69,15 +69,15 @@
    {:metamask "ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2:0xa" :status nil}
    {:metamask "ethereum:0x38cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd2" :status nil}])
 
-(deftest is-metamask-address?-test
+(deftest metamask-address?-test
   (testing "Check valid metamask addresses"
     (dorun
      (for [address valid-metamask-addresses]
-       (is (utils.address/is-metamask-address? address)))))
+       (is (utils.address/metamask-address? address)))))
   (testing "Check invalid metamask addresses"
     (dorun
      (for [address invalid-metamask-addresses]
-       (is (not (utils.address/is-metamask-address? address)))))))
+       (is (not (utils.address/metamask-address? address)))))))
 
 (deftest metamask-address->status-address-test
   (testing "Check metamask to status address conversion is valid"