fix(chat_section_module): Don't force update icon and name for 1-1 chats #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
0x-r4bbit
approved these changes
Dec 21, 2022
jrainville
approved these changes
Dec 21, 2022
| @@ -1,6 +1,6 @@ | |||
| import NimQml | |||
| import ../../../shared_models/message_model as pinned_msg_model | |||
| import ../../../../../app_service/service/contacts/dto/contacts as contacts_dto | |||
| import ../../../../../app_service/service/chat/dto/chat as chat_dto | |||
There was a problem hiding this comment.
Usually views shouldn't have access to the dto under our architecture, but it was already accessing one and TBH, it's an annoying rule, so I'll let it slide lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8273
What does the PR do
In ChatContentModule don't update name and icon for 1-1 chat. It will be updated with contact details change.
Affected areas
chat
Screenshot BEFORE
2022-12-21.11.35.34.mov
Screenshot AFTER
2022-12-21.11.38.05.mov