Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): fix image download on Windows #8867

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

jrainville
Copy link
Member

@jrainville jrainville commented Dec 20, 2022

Fixes #8755

Paths are not formatted correctly on Windows. There were three /s and also the path cannot start with /

edit: I tested on both Windows and Linux

@jrainville jrainville requested review from a team, dlipicar and mprakhov and removed request for a team December 20, 2022 20:54
@status-im-auto
Copy link
Member

status-im-auto commented Dec 20, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9ef8477 #1 2022-12-20 20:59:35 ~4 min linux-cpp 📄log
✔️ 9ef8477 #1 2022-12-20 20:59:36 ~5 min imports 📄log
✔️ 9ef8477 #1 2022-12-20 21:03:54 ~9 min macos 🍎dmg
✔️ 9ef8477 #1 2022-12-20 21:06:21 ~11 min linux 📦tgz
✔️ 9ef8477 #1 2022-12-20 21:21:23 ~26 min windows 💿exe
✔️ 9ef8477 #1 2022-12-20 21:24:22 ~29 min linux-e2e 📄log

Copy link
Contributor

@mprakhov mprakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrainville jrainville merged commit f29210d into master Dec 21, 2022
@jrainville jrainville deleted the fix/image-download branch December 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Download doesn't work
4 participants