-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tst_userIdentity): Fix test scenarios broken due to new user profile design #8845
Conversation
Jenkins BuildsClick to see older builds (6)
|
f86228f
to
c5d1c1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, I added a couple of suggestions
I'm getting random failures on "Scenario Outline: The user can change own display name in profile popup with this error": Most of the time it fails when it's running in a sequence. It is passing on re-run. @noeliaSD Can you also reproduce this? |
Not seen that but let me test again more times in sequence! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! It looks good imo. I had only the observation regarding the randomly failing test.
…file design - Fixed test scenarios broken due to new user profile design. - Added new verifications in social links: github, youtube, discord and telegram. - Scenario statements reorganization. Fixes #8281
c5d1c1f
to
ddd3a78
Compare
I can't reproduce these random failures. Could you try again fetching the new changes? I pushed yesterday some changes that corrected an issue with this second scenario.. maybe you tested with these intermediate commit?!?! |
Fixes #8281
What does the PR do
Affected areas
suite_settings/tst_userIdentity
Screenshot of functionality
Screen.Recording.2022-12-19.at.13.18.27.mov
Screen.Recording.2022-12-19.at.13.57.05.mov