Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tst_userIdentity): Fix test scenarios broken due to new user profile design #8845

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

noeliaSD
Copy link
Contributor

Fixes #8281

What does the PR do

  • Fixed test scenarios broken due to new user profile design.
  • Added new verifications for social links: github, youtube, discord and telegram.
  • Scenario statements reorganization.

Affected areas

suite_settings/tst_userIdentity

Screenshot of functionality

  1. The user sets display name, bio and social links:
Screen.Recording.2022-12-19.at.13.18.27.mov
  1. The user can change own display name in profile popup:
Screen.Recording.2022-12-19.at.13.57.05.mov

@status-im-auto
Copy link
Member

status-im-auto commented Dec 19, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f86228f #1 2022-12-19 13:10:01 ~4 min imports 📄log
✔️ f86228f #1 2022-12-19 13:10:18 ~4 min linux-cpp 📄log
✔️ f86228f #1 2022-12-19 13:15:02 ~9 min macos 🍎dmg
✔️ f86228f #1 2022-12-19 13:18:20 ~12 min linux 📦tgz
✔️ f86228f #1 2022-12-19 13:32:43 ~27 min windows 💿exe
✖️ f86228f #1 2022-12-19 13:35:55 ~30 min linux-e2e 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c5d1c1f #2 2022-12-19 14:29:47 ~4 min linux-cpp 📄log
✔️ c5d1c1f #2 2022-12-19 14:30:18 ~5 min imports 📄log
✔️ c5d1c1f #2 2022-12-19 14:31:57 ~6 min macos 🍎dmg
✔️ c5d1c1f #2 2022-12-19 14:36:46 ~11 min linux 📦tgz
✔️ c5d1c1f #2 2022-12-19 14:45:40 ~20 min windows 💿exe
✔️ c5d1c1f #2 2022-12-19 14:52:29 ~27 min linux-e2e 📄log
✔️ ddd3a78 #3 2022-12-20 08:44:19 ~4 min linux-cpp 📄log
✔️ ddd3a78 #3 2022-12-20 08:44:20 ~4 min imports 📄log
✔️ ddd3a78 #3 2022-12-20 08:50:13 ~10 min linux 📦tgz
✔️ ddd3a78 #3 2022-12-20 08:52:42 ~13 min macos 🍎dmg
✔️ ddd3a78 #3 2022-12-20 09:00:19 ~20 min windows 💿exe
✔️ ddd3a78 #3 2022-12-20 09:09:18 ~29 min linux-e2e 📄log

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I added a couple of suggestions

@alexjba
Copy link
Contributor

alexjba commented Dec 20, 2022

I'm getting random failures on "Scenario Outline: The user can change own display name in profile popup with this error":
ProfilePopup_displayName is not found, please check app for correct object and update object mapper

Most of the time it fails when it's running in a sequence. It is passing on re-run.
Looks like the popup is closed before the verification is completed.

@noeliaSD Can you also reproduce this?

@noeliaSD
Copy link
Contributor Author

I'm getting random failures on "Scenario Outline: The user can change own display name in profile popup with this error": ProfilePopup_displayName is not found, please check app for correct object and update object mapper

Most of the time it fails when it's running in a sequence. It is passing on re-run. Looks like the popup is closed before the verification is completed.

@noeliaSD Can you also reproduce this?

Not seen that but let me test again more times in sequence!

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It looks good imo. I had only the observation regarding the randomly failing test.

…file design

- Fixed test scenarios broken due to new user profile design.
- Added new verifications in social links: github, youtube, discord and telegram.
- Scenario statements reorganization.

Fixes #8281
@noeliaSD
Copy link
Contributor Author

Good job! It looks good imo. I had only the observation regarding the randomly failing test.

I can't reproduce these random failures. Could you try again fetching the new changes? I pushed yesterday some changes that corrected an issue with this second scenario.. maybe you tested with these intermediate commit?!?!

@noeliaSD noeliaSD merged commit ec8c64d into master Dec 20, 2022
@noeliaSD noeliaSD deleted the test/issue-8281 branch December 20, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suite_settings / tst_userIdentity] - All test scenarios are broken due to new user profile design
5 participants