fix(badge): show badge when mentioned even if channel is muted #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team,
dlipicar and
mprakhov
and removed request for
a team
Jenkins BuildsClick to see older builds (6)
|
mprakhov
approved these changes
Dec 9, 2022
caybro
reviewed
Dec 9, 2022
osmaczko
approved these changes
Dec 9, 2022
jrainville
force-pushed
the
fix/community-muted-badge
branch
from
88ba1f0
to
5a153d7
Compare
jrainville
force-pushed
the
fix/community-muted-badge
branch
from
5a153d7
to
0367f04
Compare
|
I messed up my rebase, do not merge |
|
Turns out my other branch was on top of this, but an older commit. So I merged this by accident, but anyway, it was already reviewed here, so I'll just merge this too to fix the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8723