Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display an error if StartMessenger fails #8555

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: display an error if StartMessenger fails #8555

merged 1 commit into from
Dec 2, 2022

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Dec 1, 2022 •
edited
Loading

@richard-ramos richard-ramos requested review from jrainville, a team and dlipicar and removed request for a team December 1, 2022 22:27
@richard-ramos richard-ramos linked an issue Dec 1, 2022 that may be closed by this pull request
StartMessenger() errors should be handled #8552
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Dec 1, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d852ecf #1 2022-12-01 22:32:39 ~4 min linux-cpp 📄log
✔️ d852ecf #1 2022-12-01 22:33:18 ~5 min imports 📄log
✔️ d852ecf #1 2022-12-01 22:39:53 ~11 min linux 📦tgz
✔️ d852ecf #1 2022-12-01 22:40:15 ~12 min macos 🍎dmg
✔️ d852ecf #1 2022-12-01 22:54:33 ~26 min linux-e2e 📄log
✔️ d852ecf #1 2022-12-01 22:56:55 ~28 min windows 💿exe

mprakhov
mprakhov approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mprakhov mprakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@richard-ramos richard-ramos merged commit 7261c78 into master Dec 2, 2022
@richard-ramos richard-ramos deleted the fix/startmessenger branch December 2, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@mprakhov mprakhov mprakhov approved these changes

@dlipicar dlipicar Awaiting requested review from dlipicar dlipicar was automatically assigned from status-im/desktop-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StartMessenger() errors should be handled
4 participants
@richard-ramos @status-im-auto @jrainville @mprakhov