feat: change title from Nim Status Client to Status Desktop #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzuqe
changed the title
| //% "Nim Status Client" | ||
| Qt.application.name = qsTrId("nim-status-client") | ||
| //% "Status Desktop" | ||
| Qt.application.name = qsTrId("status-desktop") |
There was a problem hiding this comment.
This needs to match the message-id in the .ts files: <message id="nim-status-client">
There was a problem hiding this comment.
Hey. When i change this string to the id nim-status-client, the running application reverts back to "Nim Status Desktop" even though the source for the id nim-status-client (in all the translation files) is in fact Status Desktop. I've decided to add a new commit that rather changes all the message ids to status-desktop for consistency sake.
richard-ramos
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #392
Change the title "Nim Status Client" to "Status Desktop in the translations,
main.qmlandnim-status.desktopfiles