refactor(communities): allow removing items from import file list #8165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jenkins Builds
|
caybro
approved these changes
Nov 8, 2022
| StatusFlatRoundButton { | ||
| id: removeButton | ||
| width: 32 | ||
| height: 32 |
There was a problem hiding this comment.
This explicit width/height is not gonna work inside a RowLayout; need to use Layout.preferredWidth/height
This was
linked to
issues
Nov 8, 2022
There was a requested design change where no longer wanted to have checkboxes to decide which files will be included for a discord import, but rather have an "X" button that enables users to remove items. This commit implements this refactor. In addition, it ensures that the already loaded discord categories and channels that have been extracted from validation, are kept in sync as well. Meaning, if a user removes a file from the file list, the corresponding channel will be removed as well. If there's not channel in a given category, the category will be removed as well. Closes #8125 #8126
0x-r4bbit
force-pushed
the
refactor/import-file-list
branch
from
16bb88d
to
6976adc
Compare
0x-r4bbit
force-pushed
the
fix/import-community-image
branch
2 times, most recently
from
a4bf6f7
to
a628e32
Compare
osmaczko
approved these changes
Nov 10, 2022
0x-r4bbit
force-pushed
the
fix/import-community-image
branch
from
a628e32
to
7b6d427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a requested design change where no longer wanted to have checkboxes to decide which files will be included for a discord import, but rather have an "X" button that enables users to remove items.
This commit implements this refactor.
In addition, it ensures that the already loaded discord categories and channels that have been extracted from validation, are kept in sync as well.
Meaning, if a user removes a file from the file list, the corresponding channel will be removed as well.
If there's not channel in a given category, the category will be removed as well.
Closes: #8125
Closes: #8126