chore(waku2): add extra logging #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
richard-ramos
requested review from
stefandunca,
cammellos,
iurimatias and
jrainville
stefandunca
approved these changes
Nov 7, 2022
richard-ramos
force-pushed
the
chore/extra-logging
branch
from
d55fe9d
to
2af46b7
Compare
richard-ramos
force-pushed
the
chore/extra-logging
branch
from
2af46b7
to
b19d5a8
Compare
saledjenic
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8099
Instead of enabling this only on DEBUG as requested in original issue, I'm doing it on INFO, since debug adds a lot of noise in the geth.log file, while this only logs the envelope hashes and message IDs (there's a point to discuss whether this could expose unwanted data).
Requires:
In go-waku, changes were done in https://github.com/status-im/go-waku/tree/status-go . This branch is meant only for tracing the missing messages and is not going to be merged on master.
Text to search for when tracing a message:
waku.store retrieved- Contains an array of WakuMessage hashes of all messages retrieved from store nodewaku.relay received- Contains hash of WakuMessage received via waku relaywaku.relay published- Contains hash of WakuMessage published via waku relaywaku.lightpush published- Contains hash of WakuMessage published via waku lightpushreceived waku2 store message- Indicates that a message retrieved via waku store, was received in status-gopublishing message via lightpush- Printed before sending a message with lightpush in status-gopublishing message via relay- Printed before sending a message with relay in status-gocould not send message- Contains details of any error while sending a message in status-goreceived new envelope- Indicates that a message arrived to status-go via a subscriptionprocessing message- called in handleRetrievedMessages in status-go, contains the WakuMessage hash, and the Status Message IDs contained in that WakuMessagereceivedsignal="messages.new"- Indicates which message IDs arrived to status-desktop via themessages.newsignal