Test/simple tx #7984
Merged
Test/simple tx #7984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (162)
|
alaibe
approved these changes
Oct 21, 2022
Khushboo-dev-cpp
force-pushed
the
feat/router-hop
branch
7 times, most recently
from
be983d4
to
e661cd0
Compare
Khushboo-dev-cpp
force-pushed
the
test/simpleTx
branch
2 times, most recently
from
123ad2f
to
1c1d9e4
Compare
Khushboo-dev-cpp
requested review from
a team,
iurimatias and
alexjba
and removed request for
a team
alexjba
reviewed
Oct 27, 2022
test/ui-test/testSuites/global_shared/scripts/settings_names.py
Outdated
Show resolved
Hide resolved
Khushboo-dev-cpp
force-pushed
the
test/simpleTx
branch
2 times, most recently
from
ee131bf
to
03f59bb
Compare
alexjba
approved these changes
Nov 3, 2022
stefandunca
approved these changes
Nov 7, 2022
| @@ -174,6 +174,8 @@ def check_tenor_gif_preview_is_enabled(self): | |||
| verify(tenorSwitch.enabled, "Tenor GIFs preview is enabled") | |||
|
|
|||
| def toggle_test_networks(self): | |||
| # needed cause if we do it immmediately the toggle doesn't work | |||
| time.sleep(2) | |||
There was a problem hiding this comment.
@noeliaSD is this hardcoded sleep instead of waiting for the toggle to become active a instability point that you mentioned in your presentation?
There was a problem hiding this comment.
Yeah, it could cause inestability in tests. We should try to avoid using sleeps and use waitFor instead whenever possible
| click_obj_by_name(MainWalletScreen.SEND_BUTTON_FOOTER.value) | ||
|
|
||
| squish.waitFor("float(str(wait_and_get_obj(MainWalletScreen.TOTAL_CURRENCY_BALANCE.value).text).split(' ')[0]) > 0", 60*1000) |
There was a problem hiding this comment.
@Khushboo-dev-cpp wondering how is this working.
I understand that squish will run this script for one minute or until the specific value is above 0. Is this right?
If yes, can't the same also be accomplished in Python by getting the object by the real name MainWalletScreen.TOTAL_CURRENCY_BALANCE and accessing the text property?
The only improvement, I see, over the scripting technique is that it might provide more meaningful errors and better debugging opportunities.
Khushboo-dev-cpp
force-pushed
the
test/simpleTx
branch
5 times, most recently
from
194bc1a
to
e30a940
Compare
alaibe
force-pushed
the
test/simpleTx
branch
9 times, most recently
from
1c1f07c
to
d66eddc
Compare
noeliaSD
reviewed
Nov 18, 2022
| @@ -350,7 +347,9 @@ def verify_saved_address_doesnt_exist(self, name: str): | |||
| verify_failure(f'FAIL: saved address {name} exists') | |||
|
|
|||
| def verify_transaction(self): | |||
| print("TODO: fix notification and ensure there is one") | |||
| ephemeral_notification_list = get_obj(MainWalletScreen.EPHEMERAL_NOTIFICATION_LIST.value) | |||
| squish.waitFor("ephemeral_notification_list.count > 0", 60*1000) | |||
There was a problem hiding this comment.
Could we use the driver instead of doing a direct call to squish here?
noeliaSD
reviewed
Nov 18, 2022
| print("TODO: fix notification and ensure there is one") | ||
| ephemeral_notification_list = get_obj(MainWalletScreen.EPHEMERAL_NOTIFICATION_LIST.value) | ||
| squish.waitFor("ephemeral_notification_list.count > 0", 60*1000) | ||
| verify(str(ephemeral_notification_list.itemAtIndex(0).primaryText ) == "Transaction pending...", "Tx was not sent!") |
There was a problem hiding this comment.
What will happen with this comparison if we want to run the tests in another language? :P
Could we use instead the enabled property??
alaibe
force-pushed
the
test/simpleTx
branch
12 times, most recently
from
5618a43
to
eb22c7a
Compare
alaibe
force-pushed
the
test/simpleTx
branch
from
eb22c7a
to
855c44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7983
What does the PR do
Enable test case for simple transaction
Squish wallet tests
StatusQ checklist
Screenshot of functionality (including design for comparison)