Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LinksMessageView): Reload images when back online #7813

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Oct 7, 2022

What does the PR do

When back online not loaded images didn't reload. Now images are reloaded when network is available.

Closes: #7665

Affected areas

StatusChatImageLoader, LinksMessageView

Screenshot of functionality (including design for comparison)

Kazam_screencast_00041.webm

@status-im-auto
Copy link
Member

status-im-auto commented Oct 7, 2022

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eccf107 #2 2022-10-07 12:25:37 ~4 min linux-cpp 📦pkg
eccf107 #2 2022-10-07 12:27:23 ~6 min macos 📄log
✔️ eccf107 #2 2022-10-07 12:33:41 ~12 min linux 📦tgz
⁉️ eccf107 #2 2022-10-07 12:50:16 ~13 min e2e 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ ef8806e #1 2022-10-07 12:35:20 ~14 min e2e 📄log
✔️ 3150c8f #3 2022-10-07 14:26:12 ~5 min linux-cpp 📦pkg
✔️ 3150c8f #3 2022-10-07 14:30:44 ~9 min macos 📦dmg
✔️ 3150c8f #3 2022-10-07 14:33:34 ~12 min linux 📦tgz
⁉️ 3150c8f #3 2022-10-07 15:38:22 ~13 min e2e 📄log

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some questions

ui/imports/shared/status/StatusChatImageLoader.qml Outdated Show resolved Hide resolved
@micieslak micieslak merged commit a893d10 into master Oct 11, 2022
@micieslak micieslak deleted the fix/issue-7665 branch October 11, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image messages not reloaded when back online
4 participants