chore(general): Remove profile pictures visibility options #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
0x-r4bbit,
caybro,
jrainville,
alexandraB99,
glitchminer,
saledjenic and
noeliaSD
Jenkins Builds
|
caybro
approved these changes
Oct 6, 2022
saledjenic
approved these changes
Oct 10, 2022
Exactly. I had some questions to @John-44 about profile pictures visibility and it turned out that currently we always want to display profile pictures. And it causes that those options are not needed at all. |
|
@elina2015 Could you please take a look? Merging that would close many issues :) |
|
@micieslak needs rebase |
From now on, if the image is available it should be displayed uncoditionally. Closes: #7609
micieslak
force-pushed
the
fix/issue-7609
branch
from
a95caec
to
ac9e91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
From now on, if the image is available it should be displayed uncoditionally.
Closes: #7609
Related to: #7432, #7310
Affected areas
Settings->MessagingScreenshot of functionality (including design for comparison)