feat(CommunitiesPortal): Implement text search using mocked model #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
caybro,
faust4exe,
alexandraB99,
glitchminer and
noeliaSD
Jenkins BuildsClick to see older builds (23)
|
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
8057bf5
to
2d6ed12
Compare
caybro
reviewed
Sep 29, 2022
ui/app/AppLayouts/CommunitiesPortal/CommunitiesPortalLayout.qml
Outdated
Show resolved
Hide resolved
alexandraB99
suggested changes
Sep 29, 2022
ui/app/AppLayouts/CommunitiesPortal/CommunitiesPortalLayout.qml
Outdated
Show resolved
Hide resolved
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
2d6ed12
to
5a5afa4
Compare
alexandraB99
previously requested changes
Sep 29, 2022
ui/app/AppLayouts/CommunitiesPortal/CommunitiesPortalLayout.qml
Outdated
Show resolved
Hide resolved
elina2015
requested review from
elina2015
and removed request for
glitchminer
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
5a5afa4
to
90be98c
Compare
1 task
caybro
reviewed
Sep 29, 2022
elina2015
suggested changes
Sep 30, 2022
There was a problem hiding this comment.
@micieslak there are some fixes needed:
For the empty state:
- The font size should be bigger
- The space between the tags and the text should match the Design
noeliaSD
reviewed
Oct 3, 2022
There was a problem hiding this comment.
One small issue:
- I think the searcher input should be focused by default when the user enters into this page.
Question:
- What do you mean by "Data come from dummy model because backend is not ready yet." ? Did something changed for not having the backend working now? It was already done by @richard-ramos afaik.
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
90be98c
to
1f5dd6d
Compare
|
@elina2015 Thanks for your input! I think it's already fixed :) |
Done
From what I remember from talking to John, it's not ready yet. At least current master has no real integration for that. @richard-ramos could yo comment that? |
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
1f5dd6d
to
2f38911
Compare
Additionally: - communities grid made scrollable - filtering done using SortFilterProxyModel - various adjustments to the design - clear input button added to the search input Closes: #6360
micieslak
force-pushed
the
feat/issue-6360-7299
branch
from
2f38911
to
f5d628f
Compare
micieslak
dismissed
alexandraB99’s stale review
Checked with the design and tested by Elina
|
The backend 'works' as it should return a list of communities with some of those featured, however, the logic for determining if a community is featured / popular is hardcoded and fake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Implements scrollable grid view of communities with search by text and some adjustments with design. Data come from dummy model because backend is not ready yet.
Fixes #6360
Fixes #7299
Affected areas
CommunitiesPortal
Screenshot of functionality (including design for comparison)
Kazam_screencast_00018.webm