Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix never fetching transactions #7527

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Sep 23, 2022

Fixes: #7266

The RootStore was calling checkRecentHistory on the wallet section View instead of the transaction View.

Still, the workflow is broken due to the 20 minutes timer that calls the checkRecentHistory and hangs the main thread (UI) for a long time

Required changes

Required improvements

Affected areas

Wallet activity tab view (transactions)

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
  • test changes in both light and dark theme?

The RootStore was calling checkRecentHistory on the wallet section View
instead of the transaction View.

Still the workflow is broken due to the 20 minutes timer that calls
the checkRecentHistory and hangs the the main thread (UI) for a long time

Fixes: #7266
@status-im-auto
Copy link
Member

status-im-auto commented Sep 23, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6770cbc #1 2022-09-23 12:14:28 ~19 min linux-cpp 📦pkg
✔️ 6770cbc #1 2022-09-23 12:16:13 ~20 min windows 📦exe
✔️ 6770cbc #1 2022-09-23 12:21:54 ~26 min linux 📦tgz
⁉️ 6770cbc #1 2022-09-23 12:23:47 ~28 min e2e 📄log
✔️ 6770cbc #1 2022-09-23 13:50:05 ~1 hr 54 min macos 📦dmg

@stefandunca stefandunca requested review from alaibe, a team and richard-ramos and removed request for a team September 23, 2022 12:23
@stefandunca stefandunca requested review from a team and 0x-r4bbit and removed request for a team September 23, 2022 13:12
@anastasiyaig anastasiyaig self-assigned this Sep 26, 2022
@anastasiyaig
Copy link
Contributor

anastasiyaig commented Sep 26, 2022

@stefandunca hey Stefan, can we please fix the redirect from the PN here? Or i need to log another issue? The link in the notification for pending transaction leads to mainnet instead of goerli

Also, i am still not seeing new transaction in history (i am sending on Goerli)

Screenshot 2022-09-26 at 15 15 01

https://goerli.etherscan.io/tx/0x4e3ad1289110691a28534b32d5527b5455f4031c5e86d4051d683739da7d717a

@stefandunca
Copy link
Contributor Author

stefandunca commented Sep 29, 2022

@stefandunca hey Stefan, can we please fix the redirect from the PN here? Or i need to log another issue? The link in the notification for pending transaction leads to mainnet instead of goerli

I will try to do it quickly in the current PR, if not a quick fix then I will address it with a later PR

Also, I am still not seeing new transactions in history (i am sending on Goerli)

I didn't find a quick fix for showing pending transactions and opened this issue to follow up #7530
However, it should appear after a few minutes (between 1-20) depending on where are you in the 20 minutes transaction update window.

@stefandunca stefandunca merged commit 39527a5 into master Sep 29, 2022
@stefandunca stefandunca deleted the transaction_not_shown-7266 branch September 29, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: Transaction is not shown in Activity tab without restart. Goerli transactions are not shown at all
5 participants