Fix/invitation bubble #7395
Merged
Fix/invitation bubble #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmaczko
requested review from
a team,
alaibe,
borismelnik and
glitchminer
and removed request for
a team
Jenkins BuildsClick to see older builds (8)
|
caybro
approved these changes
Sep 15, 2022
elina2015
requested review from
elina2015
and removed request for
glitchminer
InvitationBubbleView.qml: - rework view to use layouts properly - add missing community identicon Backend: - remove local community requests on community join - propagate SIGNAL_COMMUNITY_MY_REQUEST_ADDED to UI fixes: #7139
User should see `pending` state after he `join`s the community, even if that community does not require explicit admin approval. That's because currently, each member has to be accepted by admin, either automatically or manually. That means, if admin is gone, no one will be ever joined to community, even if this community states it does not require request to join.
osmaczko
force-pushed
the
fix/invitation-bubble
branch
from
9d57a46
to
556fd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvitationBubbleView.qml:
Backend:
status-go: status-im/status-go#2862
fixes: #7139
Testing notes:
Not centered text in buttons is a regression not related to this PR.
invitation-bubbles-2022-09-15_17.23.34.mp4