feat(@desktop/communities) Permissions, 'who holds' section - handling localiezed amounts #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g localiezed amounts Closes #7162
micieslak
force-pushed
the
feat/issue-7162
branch
from
a389bb4
to
11c9f7f
Compare
elina2015
requested review from
elina2015
and removed request for
anastasiyaig
faust4exe
reviewed
Sep 19, 2022
| if (Number.isInteger(num)) | ||
| return 0 | ||
|
|
||
| return num.toString().split('.')[1].length |
There was a problem hiding this comment.
Just wonder if separator is always '.'
There was a problem hiding this comment.
when using toString than yes, it's not localized
faust4exe
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Allows taking from the user and displaying token/collectible amounts using user's locale. Amounts are presented with the same number of significant digits after decimal point as the number provided by the user.
Inputcomponent is used instead ofStatusInputbecause the latter one doesn't support qml's buit-in validators.Closes #7162
Affected areas
CommunityNewPermissionView
Screenshot of functionality (including design for comparison)
Screencast.2022-09-15.13.15.02.mp4