Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@desktop/wallet): Wallet - Send - Crash after opening send modal #7185

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix(@desktop/wallet): Wallet - Send - Crash after opening send modal #7185

merged 1 commit into from
Sep 5, 2022

Conversation

Khushboo-dev-cpp
Copy link
Contributor

The error seen in the bug is linked to getSuggestedFees returning an rpc error that was unhandled, I think this should resolve this issue.

fixes #6801

What does the PR do

The error seen in the bug is linked to getSuggestedFees returning an rpc error that was unhandled, I think this should resolve this issue.

Affected areas

Wallet

@Khushboo-dev-cpp Khushboo-dev-cpp requested review from alaibe, a team and borismelnik and removed request for a team August 30, 2022 10:14
@status-im-auto
Copy link
Member

status-im-auto commented Aug 30, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 023b0e4 #1 2022-08-30 10:24:51 ~9 min macos 📦dmg
❌ 023b0e4 #1 2022-08-30 10:29:49 ~14 min windows 📄log
⁉️ 9585dc3 #2 2022-09-05 09:26:05 ~4 min linux-cpp 📄log
✔️ 9585dc3 #2 2022-09-05 09:30:28 ~8 min macos 📦dmg
✔️ 9585dc3 #2 2022-09-05 09:32:42 ~11 min linux 📦tgz
✔️ 9585dc3 #2 2022-09-05 09:48:35 ~26 min windows 📦exe

alaibe
alaibe approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@alaibe alaibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the error?

@Khushboo-dev-cpp
Copy link
Contributor Author

What is the error?

qrc:/StatusQ/src/StatusQ/Components/StatusCard.qml:489:13: QML PropertyChanges: Cannot assign to non-existent property "edit.color"
DBG 2022-08-03 20:17:53.796+01:00 NewBE_callPrivateRPC                       topics="rpc" tid=3039194 file=core.nim:20 rpc_method=wallet_getSuggestedFees
ERR 2022-08-03 20:17:54.065+01:00 rpc response error                         topics="rpc" tid=3039194 file=core.nim:29 err="\nstatus-go error [methodName:wallet_getSuggestedFees, code:-32000, message:transaction type not supported ]\n"
INF 2022-08-03 20:17:54.066+01:00 shutting down...                           topics="status-app" tid=3039194 file=nim_status_client.nim:134
qrc:/imports/shared/popups/SendModal.qml:393:33: QML GasValidator: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/imports/shared/popups/SendModal.qml:393:33: QML GasValidator: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/imports/shared/popups/SendModal.qml:393:33: QML GasValidator: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
qrc:/imports/shared/popups/SendModal.qml:393:33: QML GasValidator: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.
Traceback (most recent call last)
/Users/jenkins/workspace/status-desktop/platforms/macos/src/nim_status_client.nim(168) nim_status_client
/Users/jenkins/workspace/status-desktop/platforms/macos/src/nim_status_client.nim(143) mainProc
/Users/jenkins/workspace/status-desktop/platforms/macos/src/app/boot/app_controller.nim(233) delete
/Users/jenkins/workspace/status-desktop/platforms/macos/src/app/global/global_singleton.nim(67) delete
/Users/jenkins/workspace/status-desktop/platforms/macos/vendor/nimqml/src/nimqml/private/qqmlapplicationengine.nim(40) delete
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

this is what was reported here https://github.com/status-im/status-desktop/issues/6801

borismelnik
borismelnik reviewed Sep 1, 2022
View reviewed changes
src/app_service/service/transaction/service.nim Outdated
networks: Json.decode($response.result{"networks"}, seq[NetworkDto])
)
except Exception as e:
error "Error getting suggested fees", msg = e.msg
Copy link
Contributor

@borismelnik borismelnik Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste typo :) Error getting suggested routes :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @borismelnik !

borismelnik
borismelnik suggested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@borismelnik borismelnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small typo :)

@Khushboo-dev-cpp
fix(@desktop/wallet): Wallet - Send - Crash after opening send modal
9585dc3 
The error seen in the bug is linked to getSuggestedFees returning an rpc error that was unhandled, I think this should resolve this issue.

fixes #6801
@borismelnik borismelnik self-requested a review September 5, 2022 09:32
borismelnik
borismelnik approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@borismelnik borismelnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khushboo-dev-cpp Khushboo-dev-cpp merged commit 171b31a into master Sep 5, 2022
@Khushboo-dev-cpp Khushboo-dev-cpp deleted the fix/issue-6801 branch September 5, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaibe alaibe alaibe approved these changes

@borismelnik borismelnik borismelnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet - Send - Crash after opening send modal
4 participants
@Khushboo-dev-cpp @status-im-auto @alaibe @borismelnik