Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(community): add a test that deletes a community category #7049

Merged
merged 1 commit into from
Aug 18, 2022
Merged

test(community): add a test that deletes a community category #7049

merged 1 commit into from
Aug 18, 2022

Conversation

MishkaRogachev
Copy link
Contributor

Close #6750

What does the PR do

Add squish test case for deleting community category

@MishkaRogachev MishkaRogachev linked an issue Aug 16, 2022 that may be closed by this pull request
Automation: Can delete a community category #6750
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Aug 16, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3fa29b3 #1 2022-08-16 19:51:55 ~8 min macos 📦dmg
✔️ 3fa29b3 #1 2022-08-16 19:55:34 ~12 min linux 📦tgz
✔️ 3fa29b3 #1 2022-08-16 20:06:52 ~23 min windows 📦exe
❌ 3fa29b3 #1 2022-08-16 20:06:54 ~23 min e2e 📄log
✔️ a8eefd8 #2 2022-08-17 09:34:39 ~8 min macos 📦dmg
✔️ a8eefd8 #2 2022-08-17 09:37:01 ~10 min linux 📦tgz
✔️ a8eefd8 #2 2022-08-17 09:48:09 ~21 min windows 📦exe
❌ a8eefd8 #2 2022-08-17 10:17:09 ~50 min e2e 📄log
✔️ 95c1398 #3 2022-08-17 13:50:24 ~10 min macos 📦dmg
✔️ 95c1398 #3 2022-08-17 13:51:17 ~10 min linux 📦tgz
✔️ 95c1398 #3 2022-08-17 14:03:50 ~23 min windows 📦exe
❌ 95c1398 #3 2022-08-17 14:04:00 ~23 min e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 73be21c #4 2022-08-17 14:31:01 ~11 min linux 📦tgz
✔️ 73be21c #4 2022-08-17 14:39:44 ~20 min macos 📦dmg
✔️ 73be21c #4 2022-08-17 14:43:50 ~24 min windows 📦exe
❌ 73be21c #4 2022-08-17 14:49:34 ~30 min e2e 📄log
✔️ b969014 #5 2022-08-18 11:39:20 ~8 min macos 📦dmg
✔️ b969014 #5 2022-08-18 11:42:11 ~11 min linux 📦tgz
❌ b969014 #5 2022-08-18 11:49:40 ~19 min e2e 📄log
✔️ b969014 #5 2022-08-18 11:54:46 ~24 min windows 📦exe

@MishkaRogachev MishkaRogachev force-pushed the test/feature-6750-automation-delete-a-community-category branch from 3fa29b3 to a8eefd8 Compare August 17, 2022 09:25
@MishkaRogachev MishkaRogachev marked this pull request as ready for review August 17, 2022 09:26
noeliaSD
noeliaSD reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Some minor comments added.

test/ui-test/src/screens/StatusCommunityScreen.py Outdated Show resolved Hide resolved
test/ui-test/src/screens/StatusCommunityScreen.py Outdated Show resolved Hide resolved
test/ui-test/src/screens/StatusCommunityScreen.py Outdated Show resolved Hide resolved
test/ui-test/src/screens/StatusCommunityScreen.py Outdated Show resolved Hide resolved
test/ui-test/testSuites/suite_status/shared/scripts/sections/community_names.py Outdated Show resolved Hide resolved
test/ui-test/testSuites/suite_status/tst_communityFlows/test.feature Outdated Show resolved Hide resolved
@MishkaRogachev MishkaRogachev force-pushed the test/feature-6750-automation-delete-a-community-category branch from a8eefd8 to 95c1398 Compare August 17, 2022 13:40
jrainville
jrainville approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. If you can, update the name before merging

test/ui-test/testSuites/suite_status/shared/scripts/sections/community_names.py Outdated Show resolved Hide resolved
@MishkaRogachev MishkaRogachev force-pushed the test/feature-6750-automation-delete-a-community-category branch from 95c1398 to 73be21c Compare August 17, 2022 14:19
noeliaSD
noeliaSD approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the updates! :)

@MishkaRogachev MishkaRogachev force-pushed the test/feature-6750-automation-delete-a-community-category branch from 73be21c to b969014 Compare August 18, 2022 11:30
@MishkaRogachev MishkaRogachev merged commit 48b7f1c into master Aug 18, 2022
@MishkaRogachev MishkaRogachev deleted the test/feature-6750-automation-delete-a-community-category branch August 18, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@noeliaSD noeliaSD noeliaSD approved these changes

@stefandunca stefandunca Awaiting requested review from stefandunca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automation: Can delete a community category
4 participants
@MishkaRogachev @status-im-auto @jrainville @noeliaSD