-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Settings/Language): Can change language #7006
Conversation
@noeliaSD could you rebase before we review. There a lot of files that conflict |
Jenkins BuildsClick to see older builds (24)
|
6b0e7fa
to
2b95f18
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Just small comments
test/ui-test/testSuites/suite_status/tst_languageSettings/test.feature
Outdated
Show resolved
Hide resolved
2b95f18
to
cd46778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Except for the whole restart needed on linux after changing language part
de0236d
to
4890529
Compare
4890529
to
8956248
Compare
`tst_languageSettings`: - Feature and basic scenarios definition: Change language by selection and change language by search. - Added `StatusLanguageScreen` class and related methods to change and validate language. `SquishDriver`: - Added support to scroll at a specific list view index. - Added support to directly type into a focused element. `settings_names.py`: - Added support for object names related to `side bar` options. - Unified some nomenclature related to settings objects. `LanguageView`: - Updated to allow registering the change on Linux before the restart popup is shown so the language test can work. Closes #6903
8956248
to
1704041
Compare
Closes #6903
What does the PR do
tst_languageSettings
:StatusLanguageScreen
class and related methods to change and validate language.SquishDriver
:settings_names.py
:side bar
options.Affected areas
tst_languageSettings
Screenshot of functionality (including design for comparison)
Screen.Recording.2022-08-12.at.18.41.15.mov
Screen.Recording.2022-08-12.at.18.42.53.mov