Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Settings/Language): Can change language #7006

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

noeliaSD
Copy link
Contributor

Closes #6903

What does the PR do

tst_languageSettings:

  • Feature and basic scenarios definition: Change language by selection and change language by search.
  • Added StatusLanguageScreen class and related methods to change and validate language.

SquishDriver:

  • Added support to scroll at a specific list view index.
  • Added support to directly type into a focused element.

settings_names.py:

  • Added support for object names related to side bar options.
  • Unified some nomenclature related to settings objects.

Affected areas

tst_languageSettings

Screenshot of functionality (including design for comparison)

  • Scenario 1: Select by click, restart and validate
Screen.Recording.2022-08-12.at.18.41.15.mov
  • Scenario 2: Search and then select by click
Screen.Recording.2022-08-12.at.18.42.53.mov

@jrainville
Copy link
Member

@noeliaSD could you rebase before we review. There a lot of files that conflict

@status-im-auto
Copy link
Member

status-im-auto commented Aug 12, 2022

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5e3f3b0 #1 2022-08-12 16:59:16 ~10 min linux 📦tgz
✔️ 5e3f3b0 #1 2022-08-12 16:59:38 ~10 min macos 📦dmg
5e3f3b0 #1 2022-08-12 17:06:01 ~17 min e2e 📄log
✔️ 5e3f3b0 #1 2022-08-12 17:13:44 ~24 min windows 📦exe
✔️ 6b0e7fa #2 2022-08-16 10:14:55 ~8 min macos 📦dmg
✔️ 6b0e7fa #2 2022-08-16 10:17:43 ~11 min linux 📦tgz
✔️ 6b0e7fa #2 2022-08-16 10:32:39 ~26 min windows 📦exe
✔️ 2b95f18 #3 2022-08-16 10:21:27 ~11 min linux 📦tgz
✔️ 2b95f18 #3 2022-08-16 10:25:20 ~15 min macos 📦dmg
2b95f18 #3 2022-08-16 10:33:30 ~23 min e2e 📄log
✔️ 2b95f18 #3 2022-08-16 10:37:22 ~27 min windows 📦exe
2b95f18 #4 2022-08-16 11:47:42 ~50 min e2e 📄log
✔️ cd46778 #4 2022-08-17 07:10:40 ~8 min macos 📦dmg
✔️ cd46778 #4 2022-08-17 07:13:41 ~11 min linux 📦tgz
cd46778 #5 2022-08-17 07:15:52 ~13 min e2e 📄log
✔️ cd46778 #4 2022-08-17 07:26:02 ~23 min windows 📦exe
✔️ de0236d #5 2022-08-17 14:32:55 ~8 min macos 📦dmg
✔️ de0236d #5 2022-08-17 14:35:13 ~11 min linux 📦tgz
✔️ de0236d #5 2022-08-17 14:49:00 ~24 min windows 📦exe
de0236d #6 2022-08-17 15:00:25 ~36 min e2e 📄log
✔️ 4890529 #6 2022-08-17 15:11:13 ~8 min macos 📦dmg
✔️ 4890529 #6 2022-08-17 15:13:32 ~11 min linux 📦tgz
4890529 #7 2022-08-17 15:20:32 ~18 min e2e 📄log
✔️ 4890529 #6 2022-08-17 15:27:12 ~24 min windows 📦exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8956248 #7 2022-08-18 07:03:26 ~8 min macos 📦dmg
✔️ 8956248 #7 2022-08-18 07:06:16 ~11 min linux 📦tgz
✔️ 8956248 #7 2022-08-18 07:19:40 ~24 min windows 📦exe
8956248 #8 2022-08-18 07:25:07 ~30 min e2e 📄log
✔️ 1704041 #8 2022-08-18 08:27:06 ~8 min macos 📦dmg
✔️ 1704041 #8 2022-08-18 08:30:10 ~11 min linux 📦tgz
✔️ 1704041 #8 2022-08-18 08:43:57 ~24 min windows 📦exe
1704041 #9 2022-08-18 09:16:18 ~14 min e2e 📄log

@noeliaSD noeliaSD force-pushed the test/issue-6903 branch 2 times, most recently from 6b0e7fa to 2b95f18 Compare August 16, 2022 10:09
@noeliaSD
Copy link
Contributor Author

@noeliaSD could you rebase before we review. There a lot of files that conflict

Done!

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Just small comments

Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Except for the whole restart needed on linux after changing language part

`tst_languageSettings`:
- Feature and basic scenarios definition: Change language by selection and change language by search.
- Added `StatusLanguageScreen` class and related methods to change and validate language.

`SquishDriver`:
- Added support to scroll at a specific list view index.
- Added support  to directly type into a focused element.

`settings_names.py`:
- Added support for object names related to `side bar` options.
- Unified some nomenclature related to settings objects.

`LanguageView`:
- Updated to allow registering the change on Linux before the restart popup is shown so the language test can work.

Closes #6903
@noeliaSD noeliaSD merged commit b06bae0 into master Aug 18, 2022
@noeliaSD noeliaSD deleted the test/issue-6903 branch August 18, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can change language
4 participants