test(chat): Can do a mention in a chat #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (23)
|
noeliaSD
force-pushed
the
feat/issue-6879
branch
from
d70afec
to
490df62
Compare
noeliaSD
force-pushed
the
feat/issue-6879
branch
from
490df62
to
a98d69d
Compare
|
Please @alaibe , @jrainville test them locally and ensure the Indeed, we should need to comment out all |
noeliaSD
changed the title
jrainville
approved these changes
Aug 11, 2022
jrainville
reviewed
Aug 11, 2022
borismelnik
approved these changes
Aug 12, 2022
noeliaSD
force-pushed
the
feat/issue-6879
branch
3 times, most recently
from
e6fb96a
to
f4f2f9a
Compare
`tst_chatFlow`: - Commented out bc of `mailserver` issues and then weak. - Added basic test scenario for sending a mention in a public chat with needed validations. - Added basic test scenario to check a mention cannot be done if it is a non existing user. `StatusChatScreen` updates: - Updated join room method to validate the chat is loaded. - Added methods for doing and verifying a mention. `SquishDriver` updates: - Added support in `SquishDriver` to click into a link in a text or label component. - Minor function renames. Closes #6879
noeliaSD
force-pushed
the
feat/issue-6879
branch
from
f4f2f9a
to
d5b8730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6879
IMPORTANT: Weak test because it relys on
mailserverand if the chat history is not loaded, it will fail!!!What does the PR do
tst_chatFlow:StatusChatScreenupdates:SquishDriverupdates:SquishDriverto click into a link in a text or label component.Affected areas
tst_chatFlowScreenshot of functionality (including design for comparison)
Screen.Recording.2022-08-11.at.09.37.32.mov
Screen.Recording.2022-08-11.at.09.39.00.mov