Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(@wallet): Add test for toggling network & balance #6868

Merged
merged 1 commit into from
Aug 11, 2022
Merged

test(@wallet): Add test for toggling network & balance #6868

merged 1 commit into from
Aug 11, 2022

Conversation

alaibe
Copy link
Collaborator

@alaibe alaibe commented Aug 8, 2022 •
edited
Loading

fixes #6819

@status-im-auto
Copy link
Member

status-im-auto commented Aug 8, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (23)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 959671b #1 2022-08-08 10:18:28 ~9 min macos 📦dmg
✔️ 959671b #1 2022-08-08 10:20:51 ~11 min linux 📦tgz
✔️ 959671b #1 2022-08-08 10:33:37 ~24 min windows 📦exe
❌ 959671b #1 2022-08-08 10:34:23 ~25 min e2e 📄log
❌ 467a08e #2 2022-08-09 07:29:30 ~5 min e2e 📄log
✔️ 467a08e #2 2022-08-09 07:32:04 ~8 min macos 📦dmg
✔️ 467a08e #2 2022-08-09 07:34:46 ~11 min linux 📦tgz
✔️ 467a08e #2 2022-08-09 07:46:58 ~23 min windows 📦exe
❌ 467a08e #3 2022-08-09 08:41:40 ~6 min e2e 📄log
✔️ 467a08e #3 2022-08-09 08:43:29 ~8 min macos 📦dmg
✔️ 467a08e #3 2022-08-09 08:45:38 ~10 min linux 📦tgz
✔️ 467a08e #3 2022-08-09 08:58:05 ~23 min windows 📦exe
❌ f010c69 #4 2022-08-09 10:58:12 ~5 min e2e 📄log
✔️ f010c69 #4 2022-08-09 11:00:49 ~8 min macos 📦dmg
✔️ f010c69 #4 2022-08-09 11:03:32 ~11 min linux 📦tgz
✔️ f010c69 #4 2022-08-09 11:15:33 ~23 min windows 📦exe
✔️ f010c69 #1 2022-08-10 17:39:57 ~51 min linux 📦tgz
✔️ f010c69 #1 2022-08-10 17:44:51 ~55 min macos 📦dmg
✔️ f010c69 #1 2022-08-10 19:53:17 ~3 hr 2 min windows 📦exe
✔️ fc99900 #2 2022-08-11 07:23:52 ~8 min macos 📦dmg
✔️ fc99900 #2 2022-08-11 07:25:49 ~10 min linux 📦tgz
❌ fc99900 #5 2022-08-11 07:36:20 ~20 min e2e 📄log
✔️ fc99900 #2 2022-08-11 07:38:10 ~22 min windows 📦exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 074b08f #3 2022-08-11 07:39:53 ~8 min macos 📦dmg
✔️ 074b08f #3 2022-08-11 07:49:10 ~18 min linux 📦tgz
❌ 074b08f #6 2022-08-11 08:05:27 ~34 min e2e 📄log
✔️ 074b08f #3 2022-08-11 08:10:33 ~39 min windows 📦exe
❌ 074b08f #7 2022-08-11 08:17:34 ~11 min e2e 📄log
❌ 074b08f #8 2022-08-11 08:50:44 ~32 min e2e 📄log
❌ 074b08f #9 2022-08-11 09:27:50 ~22 min e2e 📄log
✔️ 2195a27 #4 2022-08-11 11:16:12 ~9 min macos 📦dmg
✔️ 2195a27 #4 2022-08-11 11:17:51 ~10 min linux 📦tgz
❌ 2195a27 #10 2022-08-11 11:18:08 ~11 min e2e 📄log
✔️ 2195a27 #4 2022-08-11 11:28:32 ~21 min windows 📦exe
❌ 2195a27 #11 2022-08-11 11:30:54 ~10 min e2e 📄log
⁉️ 2195a27 #12 2022-08-11 11:58:48 ~19 min e2e 📄log

jrainville
jrainville reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Could you just fix the typos and if you want change the name

test/ui-test/testSuites/suite_status/shared/steps/walletSteps.py Outdated Show resolved Hide resolved
test/ui-test/testSuites/suite_status/shared/steps/walletSteps.py Outdated Show resolved Hide resolved
ui/imports/shared/views/AssetsView.qml Outdated Show resolved Hide resolved
@alaibe alaibe requested a review from jrainville August 9, 2022 07:24
Base automatically changed from fix/test-wallet to master August 9, 2022 08:34
noeliaSD
noeliaSD requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails for me in 2 different ways:

  • It does not find the Ropsten network name.
  • It does not find the symbol.

Here a video for better understanding (first 2 runs, no network found, 3rd, no symbol found):

Screen.Recording.2022-08-09.at.11.41.46.mov

test/ui-test/src/screens/StatusWalletScreen.py
if list.itemAt(index).objectName == network_name:
click_obj(list.itemAt(index))
click_obj_by_name(MainWalletScreen.ACCOUNT_NAME.value)
time.sleep(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because switching network takes time, there is async task doing all the recalculation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And could we squish.waitFor something instead??

@alaibe
Copy link
Collaborator Author

alaibe commented Aug 9, 2022

Test might fail because of infura api key usage limit

@alaibe alaibe force-pushed the test/network-balance branch 2 times, most recently from fc99900 to 074b08f Compare August 11, 2022 07:30
@alaibe alaibe merged commit 2f7e699 into master Aug 11, 2022
@alaibe alaibe deleted the test/network-balance branch August 11, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khushboo-dev-cpp Khushboo-dev-cpp Khushboo-dev-cpp approved these changes

@noeliaSD noeliaSD noeliaSD approved these changes

@jrainville jrainville Awaiting requested review from jrainville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can see account balances per network
5 participants
@alaibe @status-im-auto @jrainville @Khushboo-dev-cpp @noeliaSD