Fix missing context menu on right click in the community column + tests #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team,
iurimatias,
stefandunca and
noeliaSD
and removed request for
a team and
iurimatias
|
@noelia-santos you are the tester for this one |
Jenkins BuildsClick to see older builds (3)
|
micieslak
approved these changes
Jul 26, 2022
| onTriggered: Global.openPopup(createCategoryPopup) | ||
| adminPopupMenu.showInviteButton = false | ||
| adminPopupMenu.popup() | ||
| adminPopupMenu.y = Qt.binding(function () { |
There was a problem hiding this comment.
could be slightly more concise with the new notation:
adminPopupMenu.y = Qt.binding(() =>
root.height - adminPopupMenu.height - createChannelOrCategoryBtn.height - 20
)
| StatusPopupMenu { | ||
| property bool showInviteButton: false | ||
|
|
||
| id: adminPopupMenu |
noeliaSD
approved these changes
Jul 26, 2022
| @@ -34,21 +34,23 @@ Feature: Status Desktop community | |||
| Scenario Outline: Admin creates a community channel | |||
There was a problem hiding this comment.
Some identation issues in the previous examples (User creates a community) scenario
|
|
||
| Scenario Outline: Admin edits a community channel | ||
| When the user creates a community named myCommunity, with description My community description, intro Community Intro and outro Community Outro | ||
| Then the user lands on the community named myCommunity | ||
| When the admin creates a community channel named test-channel, with description My description | ||
| When the admin creates a community channel named test-channel, with description My description with the method bottom_menu | ||
| Then the user lands on the community channel named test-channel | ||
| When the admin edits a community channel named <community_channel_name> to the name <new_community_channel_name> | ||
| Then the user lands on the community channel named <new_community_channel_name> |
There was a problem hiding this comment.
I'm thinking here we can add more validations, maybe in a separated task. I did some of them in the "create group chat" task, so we can take profit of some methods there and test if the toolbar name is the channel expected name, if the chat history title corresponds with the channel name and so on!
| @When("the admin creates a community channel named |any|, with description |any|") | ||
| def step(context, community_channel_name, community_channel_description): | ||
| _statusCommunityScreen.create_community_channel(community_channel_name, community_channel_description) | ||
| @When("the admin creates a community channel named |any|, with description |any| with the method |any|") |
There was a problem hiding this comment.
Another comment related to validation.. maybe we can add some validation regarding the admin user.. Can we verify the community channel is created BY THE ADMIN??
There was a problem hiding this comment.
I'm not sure. Technically, a user could not create a channel, so we can do another test later where a user joins a community and test if they can create a channel (they shouldn't be able to).
| def create_community_channel(self, communityChannelName: str, communityChannelDescription: str): | ||
| click_obj_by_name(CommunityScreenComponents.COMMUNITY_CREATE_CHANNEL_OR_CAT_BUTTON.value) | ||
| def create_community_channel(self, communityChannelName: str, communityChannelDescription: str, method: str): | ||
| if (method == "bottom_menu"): |
There was a problem hiding this comment.
Could it make sense to use an enum here instead of a string?
jrainville
force-pushed
the
fix/missing-community-context-menu
branch
from
5bdedfb
to
5c91ec2
Compare
Fixes #6609 The menu was lost because it used to be set as part of the ScrollView background, but it got changed to a Flickable as part of the fix to the scrolls being not smooth. Anyway, background doesn't exist on Flickables, so I removed it and moved the MouseArea to the CommunityColumnView instead.
jrainville
force-pushed
the
fix/missing-community-context-menu
branch
from
5c91ec2
to
6f17084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6609
The menu was lost because it used to be set as part of the ScrollView background, but it got changed to a Flickable as part of the fix to the scrolls being not smooth.
Anyway, background doesn't exist on Flickables, so I removed it and moved the MouseArea to the CommunityColumnView instead.
Second commit adds integration tests
StatusQ PR: status-im/StatusQ#802