Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Settings/ProfileLayout): TestNet banner overlaps left panel #6605

Merged
merged 1 commit into from
Aug 1, 2022
Merged

fix(Settings/ProfileLayout): TestNet banner overlaps left panel #6605

merged 1 commit into from
Aug 1, 2022

Conversation

caybro
Copy link
Member

@caybro caybro commented Jul 25, 2022

Fixes: #6600

Needs: status-im/StatusQ#798

What does the PR do

Fixes the testnet warning banner overflowing the profile layout width

Affected areas

Settings/ProfileLayout

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Snímek obrazovky z 2022-07-25 11-18-11

@caybro caybro linked an issue Jul 25, 2022 that may be closed by this pull request
TestNet banner overlaps left panel #6600
Closed
@caybro caybro marked this pull request as draft July 25, 2022 10:50
@status-im-auto
Copy link
Member

status-im-auto commented Jul 25, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4e4a13d #1 2022-07-25 10:59:30 ~11 min linux 📦tgz
✔️ 4e4a13d #1 2022-07-25 11:10:03 ~21 min macos 📦dmg
✔️ 49d332a #4 2022-07-25 11:27:38 ~11 min linux 📦tgz
✔️ 49d332a #3 2022-07-25 11:35:49 ~19 min macos 📦dmg
✔️ 49d332a #3 2022-07-25 11:37:53 ~21 min windows 📦exe
✔️ c874486 #4 2022-07-26 09:31:28 ~8 min macos 📦dmg
✔️ c874486 #5 2022-07-26 09:32:48 ~9 min linux 📦tgz
✔️ c874486 #4 2022-07-26 09:45:01 ~21 min windows 📦exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c4586bd #5 2022-07-27 09:19:22 ~8 min macos 📦dmg
✔️ c4586bd #6 2022-07-27 09:23:02 ~12 min linux 📦tgz
✔️ c4586bd #5 2022-07-27 09:35:10 ~24 min windows 📦exe
✔️ 4c75d16 #7 2022-07-27 09:27:56 ~11 min linux 📦tgz
✔️ 4c75d16 #6 2022-07-27 09:31:08 ~14 min macos 📦dmg
✔️ 4c75d16 #6 2022-07-27 09:38:42 ~21 min windows 📦exe

@caybro caybro force-pushed the 6600-testnet-banner-overlaps-left-panel branch from 4e4a13d to 4a32dc0 Compare July 25, 2022 11:00
@caybro caybro marked this pull request as ready for review July 25, 2022 11:01
@caybro caybro marked this pull request as draft July 25, 2022 11:12
@caybro caybro force-pushed the 6600-testnet-banner-overlaps-left-panel branch from 4a32dc0 to 49d332a Compare July 25, 2022 11:16
@caybro
Copy link
Member Author

caybro commented Jul 25, 2022

This can't be merged before #6584 as it contains a breaking change

@caybro caybro marked this pull request as ready for review July 25, 2022 12:46
@caybro caybro requested a review from a team July 25, 2022 14:28
@elina2015 elina2015 self-requested a review July 26, 2022 00:57
@elina2015 elina2015 self-assigned this Jul 26, 2022
@caybro caybro force-pushed the 6600-testnet-banner-overlaps-left-panel branch from 49d332a to c874486 Compare July 26, 2022 09:22
@elina2015
Copy link

@caybro hey, I tried by different ways but cannot launch the app (macOS Monterey 12.3 Beta (21E5227a)). Could you kindly check?

@caybro caybro force-pushed the 6600-testnet-banner-overlaps-left-panel branch from c874486 to c4586bd Compare July 27, 2022 09:10
@caybro
Copy link
Member Author

caybro commented Jul 27, 2022

@caybro hey, I tried by different ways but cannot launch the app (macOS Monterey 12.3 Beta (21E5227a)). Could you kindly check?

Hi @elina, I rebased the PR to fix the git conflicts in StatusQ; once it's been built, it should launch correctly

@caybro caybro force-pushed the 6600-testnet-banner-overlaps-left-panel branch from c4586bd to 4c75d16 Compare July 27, 2022 09:16
elina2015
elina2015 approved these changes Jul 29, 2022
View reviewed changes
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@elina2015 elina2015 added tested and removed testing labels Jul 29, 2022
@caybro caybro merged commit 4e81f58 into master Aug 1, 2022
@caybro caybro deleted the 6600-testnet-banner-overlaps-left-panel branch August 1, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaibe alaibe alaibe approved these changes

@elina2015 elina2015 elina2015 approved these changes

@alexandraB99 alexandraB99 alexandraB99 approved these changes

@osmaczko osmaczko osmaczko approved these changes

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

Assignees

@elina2015 elina2015

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestNet banner overlaps left panel
6 participants
@caybro @status-im-auto @elina2015 @alaibe @alexandraB99 @osmaczko