Usage of StatusMessage
#6508
Merged
Usage of StatusMessage
#6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (145)
|
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
9 times, most recently
from
95b9a89
to
fbeb3e8
Compare
✔️ status-desktop/branches/macos/PR-6508#9 🔹 ~10 min 🔹 95b9a89 🔹 📦 macos package |
✔️ status-desktop/branches/linux/PR-6508#9 🔹 ~11 min 🔹 95b9a89 🔹 📦 linux package |
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
9 times, most recently
from
e684512
to
2b76c36
Compare
igor-sirotin
requested review from
jrainville,
caybro,
Khushboo-dev-cpp,
osmaczko,
0x-r4bbit and
a team
and removed request for
a team
|
Hi @igor-sirotin, issue 12 now seems resolved but a similar problem is now appearing in long messages or larger images. Please refer to the screen recording below. Is this related to 12 or better raised as a separate issue? Screen.Recording.2022-08-17.at.21.34.56.movScreen.Recording.2022-08-17.at.21.38.51.mov |
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
6 times, most recently
from
0382ed1
to
e92c927
Compare
Issue Found@igor-sirotin, 12 is now resolved! 👍 New issues tracking comment for clarity. Issues in previous #6508 (comment) are now addressed, either fixed or moved to new issues. 3 issues found in this cycle: 13. FIXED Formatting on pinned messages (addressed later by #6851 ?)
14. MOVED Pinned message limit not reseting after removing pins (showing max at 2) (TO BE MOVED)
15. FIXED Spacing next to time stamp is too large and missing bold dot spacerActual Expected 16. FIXED Tall images not being displayed correctly
17. FIXED Chat key not included in id verification modal
|
1 task
micieslak
requested changes
Aug 19, 2022
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
2 times, most recently
from
3241b89
to
79b8170
Compare
|
@glitchminer @micieslak, thanks, both fixed: |
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
from
79b8170
to
879a91c
Compare
micieslak
approved these changes
Aug 19, 2022
| // Add a small delay because images, even though they say they say they are loaed, they aren't shown yet | ||
| Qt.callLater(chatLogView.positionViewAtBeginning) | ||
| timer.setTimeout(function() { | ||
| Qt.callLater(chatLogView.positionViewAtBeginning) |
There was a problem hiding this comment.
Is nested Qt.callLater needed?
Presumable it could be just:
timer.setTimeout(chatLogView.positionViewAtBeginning), 100)
| Qt.callLater(chatLogView.positionViewAtBeginning) | ||
| timer.setTimeout(function() { | ||
| Qt.callLater(chatLogView.positionViewAtBeginning) | ||
| }, 100); |
There was a problem hiding this comment.
please be consistent about ;. It can be removed I think.
|
|
||
| onContentYChanged: { | ||
| scrollDownButton.visible = contentHeight - (scrollY + height) > 400 | ||
| let loadMore = scrollDownButton.visible && scrollY < 500 |
There was a problem hiding this comment.
const, or alternatively could be moved directly into if
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
2 times, most recently
from
f50ad06
to
30f7daf
Compare
glitchminer
approved these changes
Aug 19, 2022
This was
linked to
issues
Aug 19, 2022
igor-sirotin
force-pushed
the
fix/StatusMessage
branch
from
30f7daf
to
0be59de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
StatusSelectStatusQ#790StatusComboBoxStatusQ#815StatusComboBox#6736Fixes:
StatusMessagecomponent from StatusQ #6334What does the PR do
StatusMessagecomponent from StatusQ library.MessageView,StatusChatInputand some other related code refactoring.Affected areas
chat
Screenshot of functionality (including design for comparison)
2022-07-27.18.28.06.mov
Features checklist
dogooding/phase-5)should work, can't check because of App is crashing when sending a transaction request in chat #6617
Youwhen current user is the message senderhasExpiredshouldRepeatHeader: Hide sender when multiple in a rowisHovered,isActiveDateGroupMessageFoundAnimationsetXPositionfunctions, auto-position to parent bypopup()callBefore-merge checklist
MessageViewproperties instead ofmodel❗MessageViewChatMessagesViewPinnedMessagesPopupAppearanceViewContactVerificationRequestPopupProfileViewActivityCenterMessageComponentView—MessageViewproperties —