Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StatusChatInput): 'Unblock' is not vertically aligned in 1-1 chat #6465

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

noeliaSD
Copy link
Contributor

@noeliaSD noeliaSD commented Jul 15, 2022

Fixes #6298

What does the PR do

StatusButton is now used correctly. There are 3 different button variations with preset heights/widths and paddings. The consumer cannot change the height without altering the expected behaviour and display of the button.

Button height is now consistent with chat input height.

Affected areas

1:1 Chat / Blocked user

Screenshot of functionality

Screenshot 2022-07-15 at 11 32 58

`StatusButton` is now used correctly. There are 3 different button variations with preset heights/widths and paddings. The consumer cannot change the height without altering the expected behaviour and display of the button.

Button height is now consistent with chat input.

Fixes #6298
@noeliaSD noeliaSD added bug Something isn't working E:Bugfixes labels Jul 15, 2022
@noeliaSD noeliaSD requested review from alaibe and endulab July 15, 2022 09:45
@noeliaSD noeliaSD self-assigned this Jul 15, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Jul 15, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a83ea02 #1 2022-07-15 09:54:32 ~8 min macos 📦dmg
✔️ a83ea02 #1 2022-07-15 09:55:37 ~9 min linux 📦tgz
✔️ a83ea02 #1 2022-07-15 10:11:48 ~25 min windows 📦exe

@endulab
Copy link
Contributor

endulab commented Jul 15, 2022

Looks good:
image

image

@elina2015 elina2015 self-requested a review July 15, 2022 15:05
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@elina2015 elina2015 added tested and removed testing labels Jul 17, 2022
@noeliaSD noeliaSD merged commit ee8477a into master Jul 18, 2022
@noeliaSD noeliaSD deleted the fix/issue-6298 branch July 18, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Unblock' is not vertically aligned in 1-1 chat
5 participants