Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Onboarding): align the 'Before you get started' popup with design #6458

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Jul 14, 2022

correct sizing, fonts, spacings, margins, etc

Fixes #6020

Needs status-im/StatusQ#776

What does the PR do

Aligns the 'Before you get started' popup with design

Affected areas

Onboarding/BeforeGetStarted

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Actual app:
Snímek obrazovky z 2022-07-14 14-29-17

Design:
Snímek obrazovky z 2022-07-14 15-17-22

correct sizing, fonts, spacings, margins, etc

Fixes #6020
@caybro caybro linked an issue Jul 14, 2022 that may be closed by this pull request
@caybro caybro requested review from a team, iurimatias, micieslak, noeliaSD, 0x-r4bbit and osmaczko and removed request for a team and iurimatias July 14, 2022 13:14
@status-im-auto
Copy link
Member

status-im-auto commented Jul 14, 2022

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 47cad1f #1 2022-07-14 13:22:59 ~8 min macos 📦dmg
✔️ 47cad1f #1 2022-07-14 13:25:17 ~10 min linux 📦tgz
✔️ 47cad1f #1 2022-07-14 18:04:09 ~4 hr 49 min windows 📦exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 04bfdba #2 2022-07-14 14:49:59 ~7 min macos 📦dmg
✔️ 04bfdba #2 2022-07-14 14:52:00 ~10 min linux 📦tgz
✔️ 04bfdba #2 2022-07-14 18:18:47 ~3 hr 36 min windows 📦exe
✔️ 5731d20 #3 2022-07-14 16:48:15 ~7 min macos 📦dmg
✔️ 5731d20 #3 2022-07-14 16:50:05 ~9 min linux 📦tgz
✔️ 5731d20 #3 2022-07-14 18:50:16 ~2 hr 9 min windows 📦exe

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also link StatusQ PR?

@caybro caybro requested a review from osmaczko July 14, 2022 16:40
Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please squash commits before merge.

@elina2015 elina2015 self-requested a review July 14, 2022 18:22
@elina2015 elina2015 self-assigned this Jul 14, 2022
@elina2015 elina2015 added testing and removed testing labels Jul 14, 2022
@elina2015 elina2015 removed their assignment Jul 15, 2022
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@caybro caybro merged commit 8e0c8a5 into master Jul 15, 2022
@caybro caybro deleted the 6020-popup-before-you-get-started-differs-from-the-designs branch July 15, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup 'Before you get started' differs from the designs
4 participants