Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@desktop/wallet): Fix for Wallet icon background color seems off in wallet settings under dark mode #6424

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Khushboo-dev-cpp
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp commented Jul 12, 2022

Fix for Wallet icon background color seems off in wallet settings under dark mode

fixes #6059

What does the PR do

Uses the correct background color for the wallet icon

Affected areas

wallet, settings

Screenshot of functionality (including design for comparison)

Screen.Recording.2022-07-12.at.3.57.24.PM.mov

@Khushboo-dev-cpp Khushboo-dev-cpp requested review from alaibe, a team, micieslak and anastasiyaig and removed request for a team July 12, 2022 13:58
@status-im-auto
Copy link
Member

status-im-auto commented Jul 12, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8899782 #1 2022-07-12 14:08:57 ~9 min linux 📦tgz
✔️ 8899782 #1 2022-07-12 14:09:11 ~10 min macos 📦dmg
✔️ 8899782 #1 2022-07-12 14:24:55 ~25 min windows 📦exe

@elina2015 elina2015 requested review from elina2015 and removed request for anastasiyaig July 12, 2022 22:55
@elina2015 elina2015 self-assigned this Jul 12, 2022
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@elina2015 elina2015 added tested and removed testing labels Jul 12, 2022
@caybro
Copy link
Member

caybro commented Jul 13, 2022

@Khushboo-dev-cpp unmark it as WIP :)

@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as ready for review July 13, 2022 11:20
@Khushboo-dev-cpp Khushboo-dev-cpp merged commit 864bdd6 into master Jul 13, 2022
@Khushboo-dev-cpp Khushboo-dev-cpp deleted the fix/issue-6059 branch July 13, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet icon background color seems off in wallet settings
6 participants