Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick crash fix #6421

Merged
merged 1 commit into from
Jul 12, 2022
Merged

quick crash fix #6421

merged 1 commit into from
Jul 12, 2022

Conversation

saledjenic
Copy link
Contributor

@anastasiyaig please test this change on top of the latest change @endulab did.

@status-im-auto
Copy link
Member

status-im-auto commented Jul 12, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 869bcf9 #1 2022-07-12 12:49:47 ~10 min macos 📦dmg
✔️ 869bcf9 #1 2022-07-12 12:51:54 ~12 min linux 📦tgz
✔️ 869bcf9 #1 2022-07-12 13:13:03 ~33 min windows 📦exe

@jrainville
Copy link
Member

I just tested this PR and I got this error, it might be the same or different than what we had before

DBG 2022-07-12 14:29:50.111-04:00 NewBE_callPrivateRPC                       topics="rpc" tid=14554 file=core.nim:20 rpc_method=wakuext_getContactByID
Traceback (most recent call last)
/home/jonathan/dev/nim-status-client/src/nim_status_client.nim(169) nim_status_client
/home/jonathan/dev/nim-status-client/src/nim_status_client.nim(166) mainProc
/home/jonathan/dev/nim-status-client/vendor/nimqml/src/nimqml/private/qguiapplication.nim(29) exec
/home/jonathan/dev/nim-status-client/vendor/nimqml/src/nimqml/private/qobject.nim(49) qobjectCallback
/home/jonathan/dev/nim-status-client/vendor/nimqml/src/nimqml/private/qobject.nim(34) onSlotCalled
/home/jonathan/dev/nim-status-client/vendor/nimbus-build-system/vendor/Nim/lib/core/macros.nim(566) onSlotCalled
/home/jonathan/dev/nim-status-client/src/app/core/signals/signals_manager.nim(56) receiveSignal
/home/jonathan/dev/nim-status-client/src/app/core/signals/signals_manager.nim(53) processSignal
/home/jonathan/dev/nim-status-client/src/app/core/eventemitter.nim(46) emit
/home/jonathan/dev/nim-status-client/src/app_service/service/contacts/service.nim(170) :anonymous
/home/jonathan/dev/nim-status-client/src/app/core/eventemitter.nim(46) emit
/home/jonathan/dev/nim-status-client/src/app/modules/main/controller.nim(171) :anonymous
/home/jonathan/dev/nim-status-client/src/app/modules/main/io_interface.nim(126) contactUpdated
/home/jonathan/dev/nim-status-client/src/app/modules/main/module.nim(742) contactUpdated
/home/jonathan/dev/nim-status-client/src/app/modules/shared_models/active_section.nim(192) updateMember
/home/jonathan/dev/nim-status-client/src/app/modules/shared_models/section_item.nim(248) updateMember
/home/jonathan/dev/nim-status-client/src/app/modules/shared_models/member_model.nim(257) updateItem
/home/jonathan/dev/nim-status-client/src/app/modules/shared_models/member_model.nim(161) findIndexForMessageId
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
make: *** [Makefile:586: run-linux] Error 1

@iurimatias iurimatias merged commit cd2d289 into master Jul 12, 2022
@iurimatias iurimatias deleted the fix/crash-fix branch July 12, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants