fix(ContactsColumnView): fix layout issues to match design #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team and
elina2015
and removed request for
a team
Jenkins BuildsClick to see older builds (3)
|
jrainville
approved these changes
Jul 8, 2022
igor-sirotin
requested changes
Jul 11, 2022
caybro
force-pushed
the
fix/contacts-column-view-layout
branch
from
2913b50
to
9568b67
Compare
igor-sirotin
approved these changes
Jul 11, 2022
Closes #6343 and #6344 - basically switch over to a column + row layout(s), bringing consistent margins and paddings, scratches a lot of redundant code - fix the icon colors - fixed another bug when opening the create chat panel, and then clicking on an existing channel in the list, doesn't close this create panel - remove unused signals and connections
caybro
force-pushed
the
fix/contacts-column-view-layout
branch
from
9568b67
to
3922d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6343
Fixes #6344
Fixes #6347
margins and paddings, scratches a lot of redundant code
on an existing channel in the list, doesn't close this create panel
What does the PR do
Mainly fixes layout issues in ContactsColumnView
Affected areas
ContactsColumnView
Screenshot of functionality (including design for comparison)