fix(@desktop/wallet): Fix visual issues in add account modal #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
alaibe,
anastasiyaig,
a team and
noeliaSD
and removed request for
a team
Jenkins BuildsClick to see older builds (5)
|
|
Probably unrelated to this PR but this input here Is that by design? |
osmaczko
approved these changes
Jul 8, 2022
alaibe
approved these changes
Jul 8, 2022
Hi @PascalPrecht does look weird, but it is as per design |
Khushboo-dev-cpp
force-pushed
the
fix/issue-6257
branch
2 times, most recently
from
894e793
to
e2fdb82
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-6257
branch
from
e2fdb82
to
e37fb6f
Compare
@Khushboo-dev-cpp actually, in the design it's even bigger which makes it more look like a text area rather than an normal text input. That's why it doesn't look "weird" in the design. Do you think this needs update in the implementation then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6257
What does the PR do
fix(@desktop/wallet): Fix visual issues in add account modal:
NOTE: There is another issue pending which is already reported separately as #6315
Affected areas
Wallet
Screenshot of functionality (including design for comparison)
Screen.Recording.2022-07-08.at.11.53.59.AM.mov