fix(CreateChatView): hide the Contacts label when no contacts #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
requested review from
alexandraB99,
osmaczko and
noeliaSD
and removed request for
noeliaSD
Jenkins BuildsClick to see older builds (4)
|
caybro
force-pushed
the
6353-contacts-is-shown-while-user-doesnt-have-any-contacts
branch
from
d4c4380
to
2802e39
Compare
- hide the TagSelector's `listLabel` and disable the `textEdit` when the contacts model is empty - add forgotten `qsTr()` - remove some no-op positioniers/anchors/width/height bindings (these are handled automatically for QQC2 Control's header and contentItem)
caybro
force-pushed
the
6353-contacts-is-shown-while-user-doesnt-have-any-contacts
branch
from
2802e39
to
c0a7f75
Compare
osmaczko
approved these changes
Jul 7, 2022
jrainville
approved these changes
Jul 7, 2022
caybro
deleted the
6353-contacts-is-shown-while-user-doesnt-have-any-contacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6353
listLabeland disable thetextEditwhen thecontacts model is empty
qsTr()handled automatically for QQC2 Control's header and contentItem)
What does the PR do
It hides the Contacts label and disables the internal tag selector when the contacts model is empty
Affected areas
CreateChatView
Screenshot of functionality (including design for comparison)
Before fix
After fix