Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@desktop/onboarding): replace placeholder text to Password #6383

Merged

Conversation

themarvi
Copy link
Contributor

@themarvi themarvi commented Jul 7, 2022

fixes: #6052

What does the PR do

Changes placeholder for password on LoginView, from 'Enter password' to 'Password' according to designs

Affected areas

Login screen, when app asks for password

Screenshot of functionality (including design for comparison)

Appearance after fix:
after-fix

  • I've checked the design and this PR matches it

@status-im-auto
Copy link
Member

status-im-auto commented Jul 7, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 6492e4f #1 2022-07-07 14:20:59 ~2 min linux-cpp 📄log
✔️ 6492e4f #1 2022-07-07 14:27:11 ~8 min macos 📦dmg
✔️ 6492e4f #1 2022-07-07 14:29:33 ~11 min linux 📦tgz
✔️ 6492e4f #1 2022-07-07 14:42:45 ~24 min windows 📦exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micieslak micieslak merged commit d97ee7a into status-im:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The wrong placeholder for the Password field on the onboarding screen
4 participants