Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6090 improve user status context menu #6333

Merged
merged 2 commits into from
Jul 12, 2022
Merged

6090 improve user status context menu #6333

merged 2 commits into from
Jul 12, 2022

Conversation

endulab
Copy link
Contributor

@endulab endulab commented Jul 4, 2022 •
edited
Loading

What does the PR do

Adjust UserStatusContextMenu to Figma design:
https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=77%3A19108

Requires StatusQ: status-im/StatusQ#749

Affected areas

UserStatusContextMenu

Screenshot of functionality

image

@endulab endulab self-assigned this Jul 4, 2022
@endulab
Copy link
Contributor Author

endulab commented Jul 4, 2022

The pr contains commit 8d6dbdf which is a part of #6058.
You can review only last commit.

@status-im-auto
Copy link
Member

status-im-auto commented Jul 4, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (7)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e06c909 #1 2022-07-04 11:02:30 ~8 min macos 📦dmg
✔️ e06c909 #1 2022-07-04 11:04:20 ~10 min linux 📦tgz
✔️ e06c909 #1 2022-07-04 11:16:44 ~22 min windows 📦exe
⁉️ 42f17ee #1 2022-07-04 11:14:39 ~2 min linux-cpp 📄log
❌ 42f17ee #2 2022-07-04 11:16:11 ~4 min macos 📄log
❌ 42f17ee #2 2022-07-04 11:17:09 ~5 min linux 📄log
❌ 42f17ee #2 2022-07-04 11:23:57 ~11 min windows 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ d2bf608 #2 2022-07-06 08:46:23 ~3 min linux-cpp 📄log
✔️ d2bf608 #3 2022-07-06 08:51:11 ~7 min macos 📦dmg
✔️ d2bf608 #3 2022-07-06 08:53:41 ~10 min linux 📦tgz
✔️ d2bf608 #3 2022-07-06 09:05:54 ~22 min windows 📦exe
✔️ 292a85b #4 2022-07-12 09:08:44 ~15 min linux 📦tgz
✔️ 292a85b #4 2022-07-12 09:13:49 ~20 min macos 📦dmg
✔️ 292a85b #4 2022-07-12 09:16:34 ~23 min windows 📦exe

@endulab endulab force-pushed the 6090-improve-userStatusContextMenu branch from e06c909 to 42f17ee Compare July 4, 2022 11:11
@endulab endulab linked an issue Jul 4, 2022 that may be closed by this pull request
Improve UserStatusContextMenu #6090
Closed
@osmaczko
Copy link
Contributor

osmaczko commented Jul 5, 2022

Changes are duplicated with #6058

Could you please make 5886-adding-automatic-status-logic the merge target? or mark it as a draft until #6058 is merged to master?

@elina2015 elina2015 self-requested a review July 5, 2022 21:56
elina2015
elina2015 approved these changes Jul 5, 2022
View reviewed changes
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved

@elina2015 elina2015 added tested and removed testing labels Jul 5, 2022
@endulab endulab force-pushed the 6090-improve-userStatusContextMenu branch from 42f17ee to d2bf608 Compare July 6, 2022 08:43
@endulab
Copy link
Contributor Author

endulab commented Jul 6, 2022

Changes are duplicated with #6058

Could you please make 5886-adding-automatic-status-logic the merge target? or mark it as a draft until #6058 is merged to master?

@osmaczko #6058 was merged. I rebased the branch.

osmaczko
osmaczko approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

0x-r4bbit
0x-r4bbit reviewed Jul 8, 2022
View reviewed changes
ui/imports/shared/popups/UserStatusContextMenu.qml
text: qsTr("Inactive")
image.source: Style.svg("statuses/inactive")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it this way, but we could also introduce these as icons and have something like icon.name:"status-inactive"

Just spitballing here :)

@endulab endulab force-pushed the 6090-improve-userStatusContextMenu branch from d2bf608 to 292a85b Compare July 12, 2022 08:52
@endulab endulab merged commit 5bbc800 into master Jul 12, 2022
@endulab endulab deleted the 6090-improve-userStatusContextMenu branch July 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x-r4bbit 0x-r4bbit 0x-r4bbit approved these changes

@elina2015 elina2015 elina2015 approved these changes

@osmaczko osmaczko osmaczko approved these changes

Assignees

@endulab endulab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UserStatusContextMenu
5 participants
@endulab @status-im-auto @osmaczko @0x-r4bbit @elina2015