Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Community): Add check for admin permissions for context menu #6308

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

borismelnik
Copy link
Contributor

Closes: #6162

What does the PR do

Add check for admin permissions for context menu

Affected areas

Community column

@borismelnik borismelnik requested review from a team, Hbouaz, caybro and stefandunca and removed request for a team June 30, 2022 13:12
@status-im-auto
Copy link
Member

status-im-auto commented Jun 30, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c2662b #1 2022-06-30 13:24:14 ~11 min linux 📦tgz
✔️ 3c2662b #1 2022-06-30 13:28:09 ~15 min macos 📦dmg
✔️ 3c2662b #1 2022-06-30 13:36:54 ~23 min windows 📦exe

@Hbouaz Hbouaz added the testing label Jul 6, 2022
@Hbouaz
Copy link

Hbouaz commented Jul 6, 2022

@borismelnik is it still normal the menu is shown on right-click with fewer options than admin?

image

The admin has in addition to the above Edit and Delete Channel

image

The empty menu is not anymore shown, but the original issue stated the expected result as should not show any menu on right click when a user is not an admin
ref: #6162

@borismelnik
Copy link
Contributor Author

@borismelnik is it still normal the menu is shown on right-click with fewer options than admin?

image

The admin has in addition to the above Edit and Delete Channel

image

The empty menu is not anymore shown, but the original issue stated the expected result as should not show any menu on right click when a user is not an admin ref: #6162

Menu should be popped up on channels, but should not be when you click on some "empty space". Your second screenshot looks like you are admin for that community.

@Hbouaz Hbouaz added tested and removed testing labels Jul 7, 2022
@borismelnik borismelnik merged commit edb014b into master Jul 8, 2022
@borismelnik borismelnik deleted the fix/issue-6162-mcommunity-menu-permissions branch July 8, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty menu in community without permissions to manage channel
5 participants