feat(@wallet): multi network history #6271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaibe
requested review from
jrainville,
richard-ramos,
anastasiyaig and
Khushboo-dev-cpp
Jenkins BuildsClick to see older builds (13)
|
| case Constants.networkMainnet: return qsTr("Mainnet"); | ||
| case Constants.networkRopsten: return qsTr("Ropsten"); | ||
| default: return qsTrId("Unknown") | ||
| switch (Web3ProviderStore.chainName) { |
There was a problem hiding this comment.
why does this show only these two networks statically? Mainnet and Ropsten? what about the others?
There was a problem hiding this comment.
on browser we decided to have only those 2, similar to how it works with ENS/stickers
There was a problem hiding this comment.
I didnt know that !! :D
Khushboo-dev-cpp
approved these changes
Jun 29, 2022
alaibe
force-pushed
the
feat/tx-history-multi-network
branch
from
7523dc5
to
47977ff
Compare
|
dont merge it yet , lets do after release |
anastasiyaig
approved these changes
Jun 30, 2022
alaibe
force-pushed
the
feat/tx-history-multi-network
branch
2 times, most recently
from
6cee2c1
to
018c036
Compare
alaibe
force-pushed
the
feat/tx-history-multi-network
branch
from
018c036
to
c4e3a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multinetwork:
Remove toggle for multi network
Clean all previous network code
status-go PR: status-im/status-go#2733
fixes #6271
fixes #4749