Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@desktop/notifications): nothing happens after clicking on any notification #6178

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic requested review from elina2015, borismelnik, a team and jrainville and removed request for a team June 21, 2022 10:45
@status-im-auto
Copy link
Member

status-im-auto commented Jun 21, 2022

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 46a2a61 #1 2022-06-21 10:53:50 ~8 min macos 📦dmg
✔️ 46a2a61 #1 2022-06-21 10:55:43 ~10 min linux 📦tgz
✔️ 46a2a61 #1 2022-06-21 11:09:05 ~23 min windows 📦exe
✔️ 93ba47c #2 2022-06-21 13:41:50 ~7 min macos 📦dmg
✔️ 93ba47c #2 2022-06-21 13:43:55 ~10 min linux 📦tgz
✔️ 93ba47c #2 2022-06-21 13:56:47 ~22 min windows 📦exe
✔️ e2b9fba #3 2022-06-23 18:07:48 ~8 min macos 📦dmg
✔️ e2b9fba #3 2022-06-23 18:09:17 ~9 min linux 📦tgz
✔️ e2b9fba #3 2022-06-23 18:22:05 ~22 min windows 📦exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 99acadc #4 2022-06-23 19:45:14 ~7 min macos 📦dmg
✔️ 99acadc #4 2022-06-23 19:47:05 ~9 min linux 📦tgz
✔️ 99acadc #4 2022-06-23 19:57:23 ~20 min windows 📦exe
✔️ 39a5637 #5 2022-07-11 07:18:42 ~9 min macos 📦dmg
✔️ 39a5637 #5 2022-07-11 07:19:40 ~10 min linux 📦tgz
✔️ 39a5637 #5 2022-07-11 07:32:46 ~23 min windows 📦exe

Copy link
Contributor

@alexandraB99 alexandraB99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, didn't test though

@iurimatias
Copy link
Member

I can't trigger the notifications, perhaps i'm doing somethign wrong? I tried one one chats, another tab selected and sending a mention. I get a normal notification but not the ephemeral one

@elina2015 elina2015 removed the request for review from a team June 22, 2022 00:48
@elina2015 elina2015 self-assigned this Jun 22, 2022
Copy link

@elina2015 elina2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved

@elina2015 elina2015 added tested and removed testing labels Jun 22, 2022
@elina2015 elina2015 removed their assignment Jun 22, 2022
@saledjenic
Copy link
Contributor Author

I can't trigger the notifications, perhaps i'm doing somethign wrong? I tried one one chats, another tab selected and sending a mention. I get a normal notification but not the ephemeral one

@iurimatias if you were using 2 apps on the same machine that's normal, cause clicking send message on the other app makes that other app the top most, and that means the app receiving a message and displaying notification is not the top most app since ephemeral notifications will be displayed only while your app is active, otherwise you will receive OS notification. Bast thing is to ask somebody to send you a mention message on the chat which is not the active one while the app receiving a message is the top most app or to use mobile app to send a message.

@saledjenic saledjenic merged commit 73abf3a into master Jul 15, 2022
@saledjenic saledjenic deleted the fix/issue-5935 branch July 15, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing happens after clicking on any notification
6 participants