-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@desktop/notifications): nothing happens after clicking on any notification #6178
Conversation
Jenkins BuildsClick to see older builds (9)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, didn't test though
46a2a61
to
93ba47c
Compare
I can't trigger the notifications, perhaps i'm doing somethign wrong? I tried one one chats, another tab selected and sending a mention. I get a normal notification but not the ephemeral one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and Approved
@iurimatias if you were using 2 apps on the same machine that's normal, cause clicking send message on the other app makes that other app the top most, and that means the app receiving a message and displaying notification is not the top most app since ephemeral notifications will be displayed only while your app is active, otherwise you will receive OS notification. Bast thing is to ask somebody to send you a mention message on the chat which is not the active one while the app receiving a message is the top most app or to use mobile app to send a message. |
93ba47c
to
e2b9fba
Compare
e2b9fba
to
99acadc
Compare
…tification Fixes: #5935
99acadc
to
39a5637
Compare
Corresponding
StatusQ
PR:clicked
signal added StatusQ#737Fixes: #5935