-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CPP/CI): basic CI setup for linux cmake build #6011
Conversation
Jenkins BuildsClick to see older builds (126)
|
0cf95ae
to
f18e35a
Compare
Linux dockerized build and AppDir generation for compilation errors Also added AppImage TODOs, basic setup for MacOS and Windows but they still need work to have at least validation running Temporary disable CPP windows/mac until limitations are addressed in a follow up commit Extra: add build configuration fixes for rest of the platforms closes: #5998
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check jenkins/docker changes, but the CMake changes LGTM.
2 questions though:
- There's no newline at most of cmake files, should we fix this?
- Should we call something like
windeployqt
on windows duringinstall
step?
I had no issue but if there is no real problem I would like not to enforce yet another thing to be minded and maintained
Didn't address this yet. Spent too much time already compiling on Linux. Will come in a later task; see #5745. |
Minimal CI setup
Beware that this branch is rebased on top of #5754, and used as a merge target for more clarity in reviewing.
AppDir
generation for compilation errors reporting. Anything more advanced will be doneAll the remaining work will be done in a follow up PR
Closes: #5998