fix(chat): removing dynamic scoping from chat section #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (39)
|
| @@ -15,6 +15,9 @@ QtObject { | |||
| property var mainModuleInst | |||
| property var privacyModuleInst | |||
| property var toastMessage | |||
| property var pinnedMessagesPopup | |||
There was a problem hiding this comment.
hey this doesnt seem consistent throughout now, for example we pass instance of the model to the sections that needs it and then call Global.openPopup(modalComponent) and now for these 3 its different.
Khushboo-dev-cpp
approved these changes
Apr 6, 2022
@Khushboo-dev-cpp I totally agree and was thinking about the same. Some popups are wrapped inside |
alexandraB99
force-pushed
the
fix/issue-4244
branch
3 times, most recently
from
d5eeccc
to
30ebaa5
Compare
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
30ebaa5
to
fecf197
Compare
| @@ -322,6 +331,7 @@ Item { | |||
| anchors.centerIn: parent | |||
| store: root.store | |||
| onClosed: { | |||
| Global.openPopup(communitiesPopupComponent) | |||
There was a problem hiding this comment.
Should it be here?
Previously it was happening on CommunityDetailPopup.closed()
MishkaRogachev
suggested changes
May 19, 2022
ui/app/AppLayouts/Chat/panels/communities/CommunityChannelsAndCategoriesBannerPanel.qml
Outdated
Show resolved
Hide resolved
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
fecf197
to
3d43877
Compare
igor-sirotin
approved these changes
May 20, 2022
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
3d43877
to
05f8e31
Compare
MishkaRogachev
approved these changes
May 24, 2022
|
This will take some time to test as all 120+ Chat test cases need to be run, I am on it while also checking every detail on Figma designs |
|
will resume testing after a rebase, as agreed with @alexandraB99 |
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
05f8e31
to
86dc079
Compare
|
@Hbouaz rebased |
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
86dc079
to
05eef73
Compare
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
05eef73
to
2ed9e54
Compare
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
2ed9e54
to
60e85e9
Compare
alexandraB99
force-pushed
the
fix/issue-4244
branch
2 times, most recently
from
c29a407
to
aa1b403
Compare
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
aa1b403
to
eec1390
Compare
|
@alexandraB99 quick check ok, if you merge I will check more on master as part of regression testing run |
alexandraB99
force-pushed
the
fix/issue-4244
branch
from
eec1390
to
91c61c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4244
What does the PR do
Removed dynamic scoping from chat section
Affected areas
Chat section